From: "H. Peter Anvin" <hpa@kernel.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Jaswinder Singh Rajput <jaswinder@infradead.org>,
Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
mj@ucw.cz
Subject: Re: [PATCH] move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h
Date: Mon, 29 Dec 2008 02:01:57 -0800 [thread overview]
Message-ID: <4958A015.1070007@kernel.org> (raw)
In-Reply-To: <20081229084851.GA12756@x200.localdomain>
Alexey Dobriyan wrote:
>
> So you don't actually have an opinion? Why are you sending patch then?
>
> > could you send another patch that moves arch/x86/pci/pci.h to
> > arch/x86/include/asm/pci_x86.h
> ^^^ ^^^
> Or should it be arch/x86/include/asm/pci.h ?
>
<asm/pci.h> already exists, though. This file contains definitions
private to the x86 implementation, whereas <asm/pci.h> contains arch
implementations of panarchitectural interfaces.
The reason for moving it was to avoid ugly ../ paths.
-hpa
next prev parent reply other threads:[~2008-12-29 10:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 13:02 [PATCH] move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h Jaswinder Singh Rajput
2008-12-29 6:57 ` Alexey Dobriyan
2008-12-29 7:58 ` Jaswinder Singh Rajput
2008-12-29 8:48 ` Alexey Dobriyan
2008-12-29 10:01 ` H. Peter Anvin [this message]
2008-12-29 10:07 ` Ingo Molnar
2008-12-29 12:12 ` Ingo Molnar
2008-12-29 12:22 ` Ingo Molnar
2008-12-29 12:41 ` Jaswinder Singh Rajput
2008-12-29 12:54 ` Sam Ravnborg
2008-12-29 12:59 ` Ingo Molnar
2008-12-29 13:01 ` Ingo Molnar
2008-12-29 13:25 ` Sam Ravnborg
2008-12-29 14:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4958A015.1070007@kernel.org \
--to=hpa@kernel.org \
--cc=adobriyan@gmail.com \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mj@ucw.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox