From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752147AbYL2QJz (ORCPT ); Mon, 29 Dec 2008 11:09:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751098AbYL2QJq (ORCPT ); Mon, 29 Dec 2008 11:09:46 -0500 Received: from mail.gmx.net ([213.165.64.20]:43735 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750822AbYL2QJp (ORCPT ); Mon, 29 Dec 2008 11:09:45 -0500 X-Authenticated: #1045983 X-Provags-ID: V01U2FsdGVkX1/zL+dgXa/zF1285U5bQZ8/sYLjPh1UcgJm75TTbj tzPuN0J0x1WPBw Message-ID: <4958F648.6010401@gmx.de> Date: Mon, 29 Dec 2008 17:09:44 +0100 From: Helge Deller User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Sam Ravnborg CC: linux-parisc@vger.kernel.org, Linux Kernel Development , Kyle McMartin , Randolph Chung , Moritz Muehlenhoff , Linus , Andrew Morton , Helge Deller Subject: Re: [PATCH 2/2] parisc: fix module loading failure of large modules References: <4958D99E.4010201@gmx.de> <4958DA54.8060003@gmx.de> <20081229154610.GA7871@uranus.ravnborg.org> In-Reply-To: <20081229154610.GA7871@uranus.ravnborg.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.49 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sam Ravnborg wrote: > On Mon, Dec 29, 2008 at 03:10:28PM +0100, Helge Deller wrote: >> [PATCH 2/2] parisc: fix module loading failure of large modules >> >> On 32bit (and sometimes 64bit) and with big kernel modules like xfs or >> ipv6 the relocation types R_PARISC_PCREL17F and R_PARISC_PCREL22F may >> fail to reach their PLT stub if we only create one big stub array for >> all sections at the beginning of the core or init section. >> >> With this patch we now instead append individual PLT stub entries >> directly at the end of the code sections where the stubs are actually >> called. This reduces the distance between the PCREL location and the >> stub entry so that the relocations can be fulfilled. >> >> The kernel module loader will call module_additional_section_size() and >> request us to return the amount of additional memory we need for the >> stubs of each section. The final section size of the code segment will >> then be increased by that value when the kernel layouts the final >> addresses of all sections. >> >> Tested with 32- and 64bit kernels. >> >> Signed-off-by: Helge Deller >> > >> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig >> index 644a70b..cbb622f 100644 >> --- a/arch/parisc/Kconfig >> +++ b/arch/parisc/Kconfig >> @@ -34,6 +34,9 @@ config RWSEM_GENERIC_SPINLOCK >> config RWSEM_XCHGADD_ALGORITHM >> bool >> >> +config ARCH_WANTS_STUBS_BEHIND_SECTIONS >> + def_bool y >> + > > The recommended practive today is: > > In some relevant Kconfig file add: > > config HAVE_MODULE_SECTION_STUBS > bool > > And then in arch/$ARCH/Kconfig do: > > config PARISC > ... > select HAVE_MODULE_SECTION_STUBS > ... > > The select are supposed to be sorted alphabetically > but people seems to use a different alphabet for > each arch. Thanks Sam, I'll change that and respin. Helge