Re: [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace

H. Peter Anvin
2008-12-27T21:16:18Z

Ingo Molnar wrote:
> * Sam Ravnborg <sam@ravnborg.org> wrote:
>
>> On Sat, Dec 27, 2008 at 01:50:04AM -0500, Mike Frysinger wrote:
>>> Use __asm__/__inline__ rather than asm/inline for all the functions
>>> exported to userspace.
>> I will imagine that we will see cleanup patches converting
>> these back to inline/asm.
>> How about doing this conversion as part of the headers_install.pl
>> script so we know it is always correct?
>>
>> Then we can keep the familiar inline/asm in the kernel headers
>> and always use the correct __asm__, __inline__ version for our
>> exported headers.
>
> or name it __asm__exported__ to make sure it isnt cleaned up away.
>

Seems better to do it automatically. We end up with cleaner-looking
code that way, too.

It doesn't solve the need for symbols in inline functions in exported
headers to have __ prefixes, though.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.