Re: [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace

Mike Frysinger
2008-12-29T11:56:42Z

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

On Saturday 27 December 2008 16:09:52 H. Peter Anvin wrote:
> Mike Frysinger wrote:
> > ...
> > #ifdef __KERNEL__
> > # define kernel_flock flock
> > #endif
> > struct kernel_flock {
> > ...
>
> FWIW, a long time ago I proposed the __kabi_ prefix for these things; I
> think it is a good thing to make userspace-visible structures stand out
> even in the kernel code itself.
>
> As such, I would suggest *not* adding the #define at all.

the convention based on linux/types.h seems to be to use __kernel_ as the
prefix, but it doesnt matter to me whether it's __kabi_ or __kernel_. i'll
start doing the latter though in the hopes it'll be less scary ;).
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]