Re: [PATCH] parisc: fix module loading failure of large kernel modules (take 4)

Rusty Russell
2008-12-31T22:16:29Z

On Thursday 01 January 2009 03:59:36 Linus Torvalds wrote:
>
> On Wed, 31 Dec 2008, Helge Deller wrote:
> >
> > [PATCH 1/2] module.c: fix module loading failure of large kernel modules
> >
> > When creating the final layout of a kernel module in memory, allow the
> > module loader to reserve some additional memory in front of a given section.
> > This is currently only needed for the parisc port which needs to put the
> > stub entries there to fulfill the 17/22bit PCREL relocations with large
> > kernel modules like xfs.
> >
> > Differences of this patch to previous versions:
> > - added weak funtion arch_module_section_size()
>
> This doesn't work.
>
> We've had this bug several times now, and one of them just very recently.
>
> Some gcc versions will inline weak functions if they are in scope

Ah, someone hit this elsewhere and thought this was an arch-specific bug.
Any chance we can just kill those compiler versions and move on with our
lives? 4.1.3 definitely doesn't have the problem.

> We don't write out that whole "__attribute__" crud.

I think what you mean is "I prefer __weak". Which is fine, and not
trivially disprovable by grep.

It's a gratuitous kernelism, but it's an inoffensive one.
Rusty.