From: Randy Dunlap <randy.dunlap@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Brownell <dbrownell@users.sourceforge.net>
Subject: [PATCH] spi.h uses/needs device.h
Date: Tue, 30 Dec 2008 20:21:28 -0800 [thread overview]
Message-ID: <495AF348.9080105@oracle.com> (raw)
In-Reply-To: <200812310006.mBV060iV029753@imap1.linux-foundation.org>
From: Randy Dunlap <randy.dunlap@oracle.com>
Include header files as used/needed:
In file included from mmotm-2008-1230-1605/drivers/leds/leds-dac124s085.c:16:
mmotm-2008-1230-1605/include/linux/spi/spi.h:66: error: field 'dev' has incomplete type
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'to_spi_device':
mmotm-2008-1230-1605/include/linux/spi/spi.h:100: warning: type defaults to 'int' in declaration of '__mptr'
mmotm-2008-1230-1605/include/linux/spi/spi.h:100: warning: initialization from incompatible pointer type
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_dev_get':
mmotm-2008-1230-1605/include/linux/spi/spi.h:106: error: implicit declaration of function 'get_device'
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_dev_put':
mmotm-2008-1230-1605/include/linux/spi/spi.h:112: error: implicit declaration of function 'put_device'
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_set_drvdata':
mmotm-2008-1230-1605/include/linux/spi/spi.h:130: error: implicit declaration of function 'dev_set_drvdata'
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_get_drvdata':
mmotm-2008-1230-1605/include/linux/spi/spi.h:135: error: implicit declaration of function 'dev_get_drvdata'
mmotm-2008-1230-1605/include/linux/spi/spi.h:135: warning: return makes pointer from integer without a cast
mmotm-2008-1230-1605/include/linux/spi/spi.h: At top level:
mmotm-2008-1230-1605/include/linux/spi/spi.h:172: error: expected declaration specifiers or '...' before 'pm_message_t'
mmotm-2008-1230-1605/include/linux/spi/spi.h:174: error: field 'driver' has incomplete type
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'to_spi_driver':
mmotm-2008-1230-1605/include/linux/spi/spi.h:179: warning: type defaults to 'int' in declaration of '__mptr'
mmotm-2008-1230-1605/include/linux/spi/spi.h:179: warning: initialization from incompatible pointer type
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_unregister_driver':
mmotm-2008-1230-1605/include/linux/spi/spi.h:192: error: implicit declaration of function 'driver_unregister'
mmotm-2008-1230-1605/include/linux/spi/spi.h: At top level:
mmotm-2008-1230-1605/include/linux/spi/spi.h:225: error: field 'dev' has incomplete type
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_master_get_devdata':
mmotm-2008-1230-1605/include/linux/spi/spi.h:271: warning: return makes pointer from integer without a cast
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_message_alloc':
mmotm-2008-1230-1605/include/linux/spi/spi.h:494: error: implicit declaration of function 'kzalloc'
mmotm-2008-1230-1605/include/linux/spi/spi.h:496: warning: assignment makes pointer from integer without a cast
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_message_free':
mmotm-2008-1230-1605/include/linux/spi/spi.h:510: error: implicit declaration of function 'kfree'
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_unregister_device':
mmotm-2008-1230-1605/include/linux/spi/spi.h:801: error: implicit declaration of function 'device_unregister'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: David Brownell <dbrownell@users.sourceforge.net>
---
include/linux/spi/spi.h | 2 ++
1 file changed, 2 insertions(+)
--- mmotm-2008-1230-1605.orig/include/linux/spi/spi.h
+++ mmotm-2008-1230-1605/include/linux/spi/spi.h
@@ -19,6 +19,8 @@
#ifndef __LINUX_SPI_H
#define __LINUX_SPI_H
+#include <linux/device.h>
+
/*
* INTERFACES between SPI master-side drivers and SPI infrastructure.
* (There's no SPI slave support for Linux yet...)
next prev parent reply other threads:[~2008-12-31 4:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200812310006.mBV060iV029753@imap1.linux-foundation.org>
2008-12-31 3:51 ` mmotm 2008-12-30-16-05 uploaded (mtd) Randy Dunlap
2008-12-31 3:59 ` mmotm 2008-12-30-16-05 uploaded (mmc) Randy Dunlap
2008-12-31 18:07 ` Pierre Ossman
2008-12-31 18:48 ` Rafael J. Wysocki
2008-12-31 4:07 ` [PATCH mmotm] input: fix function arg list Randy Dunlap
2008-12-31 4:21 ` Randy Dunlap [this message]
2009-01-01 21:58 ` [PATCH] spi.h uses/needs device.h Guennadi Liakhovetski
2008-12-31 6:26 ` [PATCH mmotm] leds-dac124s085: use header files for interfaces Randy Dunlap
2008-12-31 14:42 ` [PATCH for mmotm1230] acpi: fix unused variable warnings KOSAKI Motohiro
2008-12-31 14:45 ` [PATCH for mmotm1230] input: fix incomplete prototype of input_init_abs_bypass() KOSAKI Motohiro
2009-01-01 1:51 ` [mmotm 2008-12-30-16-05] Warning at MPT driver initialization Tetsuo Handa
2009-01-01 2:26 ` Andrew Morton
2009-01-05 16:45 ` Eric Paris
2009-01-12 22:19 ` Andrew Morton
2009-01-01 20:51 ` mmotm 2008-12-30-16-05 uploaded Valdis.Kletnieks
2009-01-02 2:31 ` Andrew Morton
2009-01-02 2:42 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495AF348.9080105@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox