From: Mike Travis <travis@sgi.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Li Zefan <lizf@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] cpumask: fix compile error in kernel/irq/proc.c
Date: Wed, 31 Dec 2008 03:55:09 -0800 [thread overview]
Message-ID: <495B5D9D.8020803@sgi.com> (raw)
In-Reply-To: <200812312136.40502.rusty@rustcorp.com.au>
Rusty Russell wrote:
> On Wednesday 31 December 2008 19:29:06 Li Zefan wrote:
>> diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
>> index 2abd3a7..5a5ac60 100644
>> --- a/kernel/irq/proc.c
>> +++ b/kernel/irq/proc.c
>> @@ -111,7 +111,7 @@ static ssize_t default_affinity_write(struct file *file,
>> if (err)
>> goto out;
>>
>> - if (!is_affinity_mask_valid(new_value)) {
>> + if (!is_affinity_mask_valid(*new_value)) {
>> err = -EINVAL;
>> goto out;
>> }
>
> This looks like one for Mike: I have *new_value in the cpumask tree.
>
> Mike?
>
> Thanks,
> Rusty.
I have the old value, but then I don't have any affinity changes in my
tree. Aren't those all in your cpumask tree?
Thanks,
Mike
prev parent reply other threads:[~2008-12-31 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 8:59 [PATCH -tip] cpumask: fix compile error in kernel/irq/proc.c Li Zefan
2008-12-31 11:06 ` Rusty Russell
2008-12-31 11:55 ` Mike Travis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495B5D9D.8020803@sgi.com \
--to=travis@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox