From: Mike Travis <travis@sgi.com>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [patch] x86: Fix incorrect __read_mostly on _boot_cpu_pda
Date: Wed, 31 Dec 2008 14:18:17 -0800 [thread overview]
Message-ID: <495BEFA9.80804@sgi.com> (raw)
In-Reply-To: <20081231214446.GA6856@localdomain>
Ravikiran G Thirumalai wrote:
> The pda rework (commit 3461b0af025251bbc6b3d56c821c6ac2de6f7209)
> to remove static boot cpu pdas introduced a bug. _boot_cpu_pda is the
> actual pda used by the boot cpu and is definitely not "__read_mostly" and
> ended up polluting the read mostly section with writes. This bug caused
> regression of about 8-10% on certain syscall intensive workloads.
>
> Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
>
> Index: linux-2.6/arch/x86/kernel/head64.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/head64.c 2008-12-30 15:28:08.000000000 -0800
> +++ linux-2.6/arch/x86/kernel/head64.c 2008-12-31 10:36:21.000000000 -0800
> @@ -27,7 +27,7 @@
> #include <asm/trampoline.h>
>
> /* boot cpu pda */
> -static struct x8664_pda _boot_cpu_pda __read_mostly;
> +static struct x8664_pda _boot_cpu_pda;
>
> #ifdef CONFIG_SMP
> /*
Thanks for catching that!
Mike
next prev parent reply other threads:[~2008-12-31 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 21:44 [patch] x86: Fix incorrect __read_mostly on _boot_cpu_pda Ravikiran G Thirumalai
2008-12-31 22:18 ` Mike Travis [this message]
2009-01-02 16:09 ` Ingo Molnar
2009-01-02 18:55 ` Ravikiran G Thirumalai
2009-01-02 19:20 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495BEFA9.80804@sgi.com \
--to=travis@sgi.com \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox