Re: libusb broken on 2.6.28 x86_64 ?

[Mark Lord <lkml@rtr.ca>]

Greg KH wrote:
..
> Hm, care to run 'git bisect'?
..

No, thanks.  But the number of USB core changes in 2.6.28 is rather small,
so I just ended up looking at each of them in more detail.

This patch, below, FIXES it for me, by undoing a change from 2.6.28.

Signed-off-by: Mark Lord <mlord@pobox.com>

--- old/drivers/usb/core/driver.c	2008-12-24 18:26:37.000000000 -0500
+++ linux/drivers/usb/core/driver.c	2009-01-02 04:34:11.000000000 -0500
@@ -279,9 +279,7 @@
 	 * altsetting means creating new endpoint device entries).
 	 * When either of these happens, defer the Set-Interface.
 	 */
-	if (intf->cur_altsetting->desc.bAlternateSetting == 0)
-		;	/* Already in altsetting 0 so skip Set-Interface */
-	else if (!error && intf->dev.power.status == DPM_ON)
+	if (!error && intf->dev.power.status == DPM_ON)
 		usb_set_interface(udev, intf->altsetting[0].
 				desc.bInterfaceNumber, 0);
 	else