From: Randy Dunlap <randy.dunlap@oracle.com>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@linux-foundation.org>,
Henrik Rydberg <rydberg@euromail.se>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.28-mmotm1230 drivers/input/input.c warning msg
Date: Fri, 02 Jan 2009 08:10:35 -0800 [thread overview]
Message-ID: <495E3C7B.50505@oracle.com> (raw)
In-Reply-To: <27989.1230891358@turing-police.cc.vt.edu>
Valdis.Kletnieks@vt.edu wrote:
> patch input-allow-certain-ev_abs-events-to-bypass-all-filtering.patch
> caused a new warning to be added to the compile:
>
> CC drivers/input/input.o
> drivers/input/input.c:1661: warning: function declaration isn’t a prototype
>
> Fix up the declaration so the compiler knows what the prototype is.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
This is the third patch like this that's been posted, so I'll ack this one. ;)
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> --- linux-2.6.28-mmotm1230/drivers/input/input.c.dist 2009-01-01 17:23:02.000000000 -0500
> +++ linux-2.6.28-mmotm1230/drivers/input/input.c 2009-01-02 05:09:12.000000000 -0500
> @@ -1657,7 +1657,7 @@ static const struct file_operations inpu
> .open = input_open_file,
> };
>
> -static void __init input_init_abs_bypass()
> +static void __init input_init_abs_bypass(void)
> {
> const unsigned int *p;
> for (p = input_abs_bypass_init_data; *p; p++)
>
--
~Randy
prev parent reply other threads:[~2009-01-02 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-02 10:15 2.6.28-mmotm1230 drivers/input/input.c warning msg Valdis.Kletnieks
2009-01-02 16:10 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495E3C7B.50505@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox