* 2.6.28-mmotm1230 drivers/input/input.c warning msg
@ 2009-01-02 10:15 Valdis.Kletnieks
2009-01-02 16:10 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Valdis.Kletnieks @ 2009-01-02 10:15 UTC (permalink / raw)
To: Andrew Morton, Henrik Rydberg; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
patch input-allow-certain-ev_abs-events-to-bypass-all-filtering.patch
caused a new warning to be added to the compile:
CC drivers/input/input.o
drivers/input/input.c:1661: warning: function declaration isnât a prototype
Fix up the declaration so the compiler knows what the prototype is.
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
--- linux-2.6.28-mmotm1230/drivers/input/input.c.dist 2009-01-01 17:23:02.000000000 -0500
+++ linux-2.6.28-mmotm1230/drivers/input/input.c 2009-01-02 05:09:12.000000000 -0500
@@ -1657,7 +1657,7 @@ static const struct file_operations inpu
.open = input_open_file,
};
-static void __init input_init_abs_bypass()
+static void __init input_init_abs_bypass(void)
{
const unsigned int *p;
for (p = input_abs_bypass_init_data; *p; p++)
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.6.28-mmotm1230 drivers/input/input.c warning msg
2009-01-02 10:15 2.6.28-mmotm1230 drivers/input/input.c warning msg Valdis.Kletnieks
@ 2009-01-02 16:10 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2009-01-02 16:10 UTC (permalink / raw)
To: Valdis.Kletnieks; +Cc: Andrew Morton, Henrik Rydberg, linux-kernel
Valdis.Kletnieks@vt.edu wrote:
> patch input-allow-certain-ev_abs-events-to-bypass-all-filtering.patch
> caused a new warning to be added to the compile:
>
> CC drivers/input/input.o
> drivers/input/input.c:1661: warning: function declaration isn’t a prototype
>
> Fix up the declaration so the compiler knows what the prototype is.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
This is the third patch like this that's been posted, so I'll ack this one. ;)
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> --- linux-2.6.28-mmotm1230/drivers/input/input.c.dist 2009-01-01 17:23:02.000000000 -0500
> +++ linux-2.6.28-mmotm1230/drivers/input/input.c 2009-01-02 05:09:12.000000000 -0500
> @@ -1657,7 +1657,7 @@ static const struct file_operations inpu
> .open = input_open_file,
> };
>
> -static void __init input_init_abs_bypass()
> +static void __init input_init_abs_bypass(void)
> {
> const unsigned int *p;
> for (p = input_abs_bypass_init_data; *p; p++)
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-02 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-02 10:15 2.6.28-mmotm1230 drivers/input/input.c warning msg Valdis.Kletnieks
2009-01-02 16:10 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox