Re: [osd-dev] [PATCH 1/9] exofs: osd Swiss army knife

Alan Cox
2009-01-13T13:56:22Z

> > +#define EXOFS_SUPER_ID 0x10000 /* object ID for on-disk superblock */

And if an OS failure breaks the super block and you have only one how do
you recover it ?

> > +#define EXOFS_BM_ID 0x10001 /* object ID for ID bitmap */
> > +#define EXOFS_ROOT_ID 0x10002 /* object ID for root directory */
> > +#define EXOFS_TEST_ID 0x10003 /* object ID for test object */

Ditto some of the others

> > + EXOFS_UINT64_MAX = (~0LL),
> > + EXOFS_MAX_INO_ID = (sizeof(ino_t) * 8 == 64) ? EXOFS_UINT64_MAX :
> > + (1LL << (sizeof(ino_t) * 8 - 1)),

Ok so thats quite a big number

> > + uint32_t s_nextid; /* Highest object ID used */

but that is a smaller one

> > + uint32_t s_numfiles; /* Number of files on fs */

as is this

> > + uint32_t i_atime; /* Access time */
> > + uint32_t i_ctime; /* Creation time */
> > + uint32_t i_mtime; /* Modification time */

2038 ? - bits are cheap