From: Jiri Slaby <jirislaby@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Robert Hancock <hancockr@shaw.ca>,
linux-kernel@vger.kernel.org, david@lang.hm,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: early exception error
Date: Mon, 05 Jan 2009 16:14:12 +0100 [thread overview]
Message-ID: <496223C4.20307@gmail.com> (raw)
In-Reply-To: <20090105150150.GF7645@localhost>
On 01/05/2009 04:01 PM, Cyrill Gorcunov wrote:
> [Jiri Slaby - Mon, Jan 05, 2009 at 03:51:26PM +0100]
> | On 01/05/2009 02:08 PM, Andi Kleen wrote:
> | > +#define EARLY_BUG_ON(x) do { if (unlikely(!(x))) EARLY_BUG(); } while (0)
> |
> | I think unintentionally inverted logic.
>
> just second ! is missed :)
None is needed, two '!' are added in the macro itself while it passes the
parameter to the builtin.
> |
> | > +#define EARLY_BUG_ON(x) do {} while(0)
> |
> | Shouldn't be x referenced here?
> |
>
> but for what?
I know, core devs are sane, but e.g. for reasons such as
{'a' is used here already}
EARLY_BUG_ON(!(a = readl(...)))
{use 'a' again}
to stay on the safe side.
next prev parent reply other threads:[~2009-01-05 15:14 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 22:21 early exception error david
2008-12-30 21:26 ` Cyrill Gorcunov
2008-12-30 22:31 ` david
2008-12-30 21:41 ` Cyrill Gorcunov
2008-12-30 22:48 ` david
2008-12-31 0:25 ` Andi Kleen
2008-12-31 1:39 ` david
2008-12-31 1:25 ` Andi Kleen
2008-12-31 9:38 ` Cyrill Gorcunov
2008-12-31 19:12 ` david
2008-12-31 18:30 ` Cyrill Gorcunov
2008-12-31 19:50 ` Andi Kleen
2008-12-31 20:20 ` Cyrill Gorcunov
2008-12-31 20:59 ` david
2009-01-01 4:17 ` Andi Kleen
2009-01-01 6:17 ` david
2009-01-01 14:02 ` Andi Kleen
2009-01-02 18:21 ` david
2009-01-02 17:24 ` Cyrill Gorcunov
2009-01-02 20:57 ` Robert Hancock
2009-01-05 9:26 ` Johannes Weiner
2009-01-05 13:08 ` Andi Kleen
2009-01-05 14:51 ` Jiri Slaby
2009-01-05 15:01 ` Cyrill Gorcunov
2009-01-05 15:14 ` Jiri Slaby [this message]
2009-01-05 15:30 ` Cyrill Gorcunov
2009-01-05 15:39 ` Jiri Slaby
2009-01-05 15:42 ` Cyrill Gorcunov
2009-01-05 14:51 ` Jiri Slaby
2008-12-31 20:07 ` david
2008-12-31 19:12 ` Cyrill Gorcunov
2008-12-31 21:18 ` david
2008-12-31 20:23 ` Cyrill Gorcunov
2008-12-31 20:27 ` Cyrill Gorcunov
2008-12-31 22:30 ` Cyrill Gorcunov
[not found] <alpine.DEB.1.10.0901021029010.21408@asgard.lang.hm>
[not found] ` <20090102173441.GC5372@localhost>
[not found] ` <alpine.DEB.1.10.0901021044460.21408@asgard.lang.hm>
[not found] ` <20090102174845.GD5372@localhost>
[not found] ` <20090102175226.GE5372@localhost>
[not found] ` <alpine.DEB.1.10.0901021131210.21567@asgard.lang.hm>
[not found] ` <20090102203058.GH5372@localhost>
[not found] ` <alpine.DEB.1.10.0901030823190.23262@asgard.lang.hm>
[not found] ` <20090103161052.GB11093@localhost>
[not found] ` <alpine.DEB.1.10.0901031118450.23262@asgard.lang.hm>
2009-01-03 19:03 ` Cyrill Gorcunov
2009-01-03 21:24 ` Cyrill Gorcunov
2009-01-04 0:24 ` Jiri Slaby
2009-01-04 0:59 ` Andi Kleen
2009-01-04 10:32 ` Cyrill Gorcunov
2009-01-04 11:11 ` Cyrill Gorcunov
2009-01-04 11:29 ` Cyrill Gorcunov
2009-01-04 12:23 ` Jiri Slaby
2009-01-05 22:20 ` david
2009-01-05 21:25 ` Cyrill Gorcunov
2009-01-05 23:20 ` david
2009-01-06 8:01 ` Cyrill Gorcunov
2009-01-05 21:55 ` Yinghai Lu
2009-01-05 22:07 ` Yinghai Lu
2009-01-05 23:20 ` david
2009-01-06 0:50 ` david
2009-01-06 0:54 ` david
2009-01-06 0:02 ` Yinghai Lu
2009-01-06 1:22 ` david
2009-01-06 0:25 ` Yinghai Lu
2009-01-06 2:03 ` david
2009-01-06 1:06 ` Yinghai Lu
2009-01-06 5:29 ` david
2009-01-06 6:09 ` Yinghai Lu
2009-01-07 7:49 ` david
2009-01-05 23:18 ` david
2009-01-05 22:29 ` Yinghai Lu
2009-01-05 22:31 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496223C4.20307@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=david@lang.hm \
--cc=gorcunov@gmail.com \
--cc=hancockr@shaw.ca \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox