public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@elte.hu>, Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: fix x86_32 builds for summit and es7000 arch's
Date: Mon, 05 Jan 2009 17:09:41 -0800	[thread overview]
Message-ID: <4962AF55.9060704@sgi.com> (raw)
In-Reply-To: <4962A756.2070507@sgi.com>

Mike Travis wrote:
> Yinghai Lu wrote:
>> In file included from arch/x86/mach-generic/summit.c:16:
>> /home/yhlu/xx/xx/kernel/tip/linux-2.6/arch/x86/include/asm/summit/apic.h:
>> In function ‘cpu_mask_to_apicid_and’:
>> /home/yhlu/xx/xx/kernel/tip/linux-2.6/arch/x86/include/asm/summit/apic.h:179:
>> error: ‘GFP_ATOMIC’ undeclared (first use in this function)
>> /home/yhlu/xx/xx/kernel/tip/linux-2.6/arch/x86/include/asm/summit/apic.h:179:
>> error: (Each undeclared identifier is reported only once
>> /home/yhlu/xx/xx/kernel/tip/linux-2.6/arch/x86/include/asm/summit/apic.h:179:
>> error: for each function it appears in.)
>>
>> YH
>>
> 
> Hi Yinghai,
> 
> Thanks for catching this, I'm looking at it now.  We had a bit of a power
> problem here and have been down for a while.
> 
> Thanks,
> Mike

Subject: x86: fix x86_32 builds for summit and es7000 arch's

Impact: fix build errors on x86_32

Fix the following build errors reported by Yinghai Lu:

| In file included from arch/x86/mach-generic/summit.c:16:
| /home/yhlu/xx/xx/kernel/tip/linux-2.6/arch/x86/include/asm/summit/apic.h:
| In function ââ?¬Ë?cpu_mask_to_apicid_andââ?¬â?¢:
| /home/yhlu/xx/xx/kernel/tip/linux-2.6/arch/x86/include/asm/summit/apic.h:179:
| error: ââ?¬Ë?GFP_ATOMICââ?¬â?¢ undeclared (first use in this function)
| /home/yhlu/xx/xx/kernel/tip/linux-2.6/arch/x86/include/asm/summit/apic.h:179:
| error: (Each undeclared identifier is reported only once
| /home/yhlu/xx/xx/kernel/tip/linux-2.6/arch/x86/include/asm/summit/apic.h:179:
| error: for each function it appears in.)
| 
| YH

Note: tested build only.

Based on tip/cpus4096: v2.6.28-5703-g1d1a70e

Signed-off-by: Mike Travis <travis@sgi.com>
---
 arch/x86/include/asm/es7000/apic.h |    2 ++
 arch/x86/include/asm/summit/apic.h |    1 +
 2 files changed, 3 insertions(+)

--- linux-2.6-for-ingo.orig/arch/x86/include/asm/es7000/apic.h
+++ linux-2.6-for-ingo/arch/x86/include/asm/es7000/apic.h
@@ -1,6 +1,8 @@
 #ifndef __ASM_ES7000_APIC_H
 #define __ASM_ES7000_APIC_H
 
+#include <linux/gfp.h>
+
 #define xapic_phys_to_log_apicid(cpu) per_cpu(x86_bios_cpu_apicid, cpu)
 #define esr_disable (1)
 
--- linux-2.6-for-ingo.orig/arch/x86/include/asm/summit/apic.h
+++ linux-2.6-for-ingo/arch/x86/include/asm/summit/apic.h
@@ -2,6 +2,7 @@
 #define __ASM_SUMMIT_APIC_H
 
 #include <asm/smp.h>
+#include <linux/gfp.h>
 
 #define esr_disable (1)
 #define NO_BALANCE_IRQ (0)

  reply	other threads:[~2009-01-06  1:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-05 23:05 compiling error Yinghai Lu
2009-01-06  0:35 ` Mike Travis
2009-01-06  1:09   ` Mike Travis [this message]
2009-01-06 12:28     ` [PATCH] x86: fix x86_32 builds for summit and es7000 arch's Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4962AF55.9060704@sgi.com \
    --to=travis@sgi.com \
    --cc=Yinghai.Lu@Sun.COM \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox