Re: [patch] x86: make UV support optional

[Mike Travis <travis@sgi.com>]

Nick Piggin wrote:
> On Tue, Jan 06, 2009 at 08:33:30AM -0600, Jack Steiner wrote:
>> On Tue, Jan 06, 2009 at 07:03:48AM +0100, Nick Piggin wrote:
>>> UV is fairly rare.... and much of the support is already there to cope with
>>> 32-bit builds. So this makes sense I think.

What, you haven't heard of "UV on a chip"?  It will be in every
smart phone soon... ;-)

>>>
>>
>> Looks ok to me. One suggestion though. There is a MAXSMP config
>> option. I would suggest enabling UV if MAXSMP is enabled. This
>> will help ensure that UV is tested more frequently & may minimize
>> regressions.
> 
> Yeah.... I don't know. OTOH it would be more logical to enable
> MAXSMP iff UV is enabled (or change the MAXSMP limits for when
> UV is enabled). Or you could select Intel CPUs if UV is enabled,
> or disable GRU if UV is not set etc etc.
> 
> I didn't want to get too fancy with config options because arbitrary
> linkages seem to just cause headaches. I figure if someone wants
> to enable it, they can do so.
> 

Hi Nick,

The problem arises that if the option becomes too obscure (and never
enabled), then it won't get tested.  We (as many companies do) rely on
distros to certify applications and security features using a standard
kernel, and if an option (such as X86_UV) causes any problems whatsoever,
they'll drop it and we no longer have that application certification.

Currently, Ingo's test setup sets MAXSMP quite a bit and he's found
many problems with large NR_CPUS counts that we never would have found
ourselves.  Please don't make that process any harder.

In fact, 13k is peanuts.  Why don't you set something like "very minimal
support" and drop all obsolete features, anything older than a couple of
years, anything not available from Dell ;-)  Perhaps call it "Desktop
System"?

Thanks,
Mike