From: David Howells <dhowells@redhat.com>
To: Davi Arnaut <davi.arnaut@gmail.com>
Cc: David Howells <dhowells@redhat.com>,
akpm@osdl.org, vsu@altlinux.ru, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] strndup_user (v3), convert (keyctl)
Date: Wed, 01 Mar 2006 14:06:20 +0000 [thread overview]
Message-ID: <4967.1141221980@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060220170913.b232dc20.davi.arnaut@gmail.com>
Davi Arnaut <davi.arnaut@gmail.com> wrote:
> In keyctl_keyring_search() there wasn't a check for type[0] == '.', but your
> mm-patch added one implicitly. Which one is correct ?
Ummm... good point. Key types beginning with a dot are special, and userspace
isn't allowed to create them. I'm not sure whether they should be findable or
not, but I'm happy go for not at the moment (so the patch is correct, not the
original).
There's another minor problem with your patch:
warthog>grep -r strndup_user *
warthog1>
I take it that this isn't in Linus's kernel yet... However, I don't want my
patch to be held up too much since there are some awkward holes that need
fixing. I'm definitely in favour of strndup_user() though.
David
next prev parent reply other threads:[~2006-03-01 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-18 14:36 [PATCH 2/2] strndup_user (v3), convert (keyctl) Davi Arnaut
2006-02-18 16:44 ` David Howells
2006-02-18 19:11 ` Davi Arnaut
2006-02-20 10:24 ` David Howells
2006-02-20 10:38 ` David Howells
2006-02-20 20:09 ` Davi Arnaut
2006-03-01 14:06 ` David Howells [this message]
2006-03-01 15:16 ` Davi Arnaut
2006-03-01 20:50 ` Andrew Morton
2006-03-01 21:04 ` Davi Arnaut
2006-03-01 22:06 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4967.1141221980@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davi.arnaut@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vsu@altlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox