Re: gcc inlining heuristics was Re: [PATCH -v7][RFC]: mutex: implement adaptive spinning

Andi Kleen
2009-01-21T09:05:59Z

On Wed, Jan 21, 2009 at 09:52:08AM +0100, Nick Piggin wrote:
> On Wed, Jan 21, 2009 at 09:54:02AM +0100, Andi Kleen wrote:
> > > GCC 4.3.2. Maybe i missed something obvious?
> >
> > The typical use case of restrict is to tell it that multiple given
> > arrays are independent and then give the loop optimizer
> > more freedom to handle expressions in the loop that
> > accesses these arrays.
> >
> > Since there are no loops in the list functions nothing changed.
> >
> > Ok presumably there are some other optimizations which
> > rely on that alias information too, but again the list_*
> > stuff is probably too simple to trigger any of them.
>
> Any function that does several interleaved loads and stores
> through different pointers could have much more freedom to
> move loads early and stores late.

For once that would require more live registers. It's not
a clear and obvious win. Especially not if you have
only very little registers, like on 32bit x86.

Then it would typically increase code size.

Then x86s tend to have very very fast L1 caches and
if something is not in L1 on reads then the cost of fetching
something for a read dwarfs the few cycles you can typically
get out of this.

And lastly even on a in order system stores can
be typically queued without stalling, so it doesn't
hurt to do them early.

Also at least x86 gcc normally doesn't do scheduling
beyond basic blocks, so any if () shuts it up.

-Andi
--
ak@linux.intel.com -- Speaking for myself only.