From: James Chapman <jchapman@katalix.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, devel@openvz.org, xemul@openvz.org,
Cyrill Gorcunov <gorcunov@openvz.org>
Subject: Re: [RFC 3/4] net: pppol2tp - introduce net-namespace functionality
Date: Sat, 10 Jan 2009 11:06:08 +0000 [thread overview]
Message-ID: <49688120.9000507@katalix.com> (raw)
In-Reply-To: <4967accc.0c58560a.2ee6.3de4@mx.google.com>
Cyrill Gorcunov wrote:
> - Each tunnel and appropriate lock are inside own namespace now.
> - pppox code allows to create per-namespace sockets for
> both PX_PROTO_OE and PX_PROTO_OL2TP protocols. Actually since
> now pppox_create support net-namespaces new PPPo... protocols
> (if they ever will be) should support net-namespace too otherwise
> explicit check for &init_net would be needed.
>
> CC: James Chapman <jchapman@katalix.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
> drivers/net/pppol2tp.c | 164 ++++++++++++++++++++++++++++++++++++-------------
> drivers/net/pppox.c | 4 -
> 2 files changed, 121 insertions(+), 47 deletions(-)
Looks ok from a pppol2tp point of view, though I'm not an expert on the
netns stuff.
The patches don't apply against latest net-next-2.6. If you respin the
patches, I'll test them for pppol2tp.
--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development
next prev parent reply other threads:[~2009-01-10 11:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090109195154.320495476@gmail.com>
2009-01-09 19:51 ` [RFC 1/4] net: pppoe - code cleanup and helpers Cyrill Gorcunov
2009-01-09 19:51 ` [RFC 2/4] net: pppoe - introduce net-namespace functionality Cyrill Gorcunov
2009-01-09 19:51 ` [RFC 3/4] net: pppol2tp " Cyrill Gorcunov
2009-01-10 11:06 ` James Chapman [this message]
2009-01-10 11:13 ` Cyrill Gorcunov
2009-01-10 12:54 ` Cyrill Gorcunov
2009-01-10 13:13 ` James Chapman
2009-01-10 15:05 ` James Chapman
2009-01-10 15:19 ` Cyrill Gorcunov
2009-01-10 16:12 ` Cyrill Gorcunov
2009-01-10 18:14 ` James Chapman
2009-01-10 18:51 ` Cyrill Gorcunov
2009-01-11 7:36 ` David Miller
2009-01-09 19:51 ` [RFC 4/4] net: ppp_generic " Cyrill Gorcunov
2009-01-10 9:22 ` Cyrill Gorcunov
2009-01-10 9:28 ` Cyrill Gorcunov
2009-01-11 0:33 ` Paul Mackerras
2009-01-11 7:39 ` David Miller
2009-01-11 7:46 ` Cyrill Gorcunov
2009-01-11 8:25 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49688120.9000507@katalix.com \
--to=jchapman@katalix.com \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=gorcunov@gmail.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox