* [PATCH] x86: make 32bit MAX_HARDIRQSS_PER_CPU to be NR_VECTORS
@ 2009-01-12 19:54 Yinghai Lu
2009-01-14 11:17 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Yinghai Lu @ 2009-01-12 19:54 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, H. Peter Anvin; +Cc: linux-kernel@vger.kernel.org
Impact: clean up to be same as 64bit
32bit is use per-cpu vector too, so don't use default NR_IRQS
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/include/asm/hardirq_32.h | 3 +++
arch/x86/include/asm/irq_vectors.h | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
Index: linux-2.6/arch/x86/include/asm/hardirq_32.h
===================================================================
--- linux-2.6.orig/arch/x86/include/asm/hardirq_32.h
+++ linux-2.6/arch/x86/include/asm/hardirq_32.h
@@ -20,6 +20,9 @@ typedef struct {
DECLARE_PER_CPU(irq_cpustat_t, irq_stat);
+/* We can have at most NR_VECTORS irqs routed to a cpu at a time */
+#define MAX_HARDIRQS_PER_CPU NR_VECTORS
+
#define __ARCH_IRQ_STAT
#define __IRQ_STAT(cpu, member) (per_cpu(irq_stat, cpu).member)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: make 32bit MAX_HARDIRQSS_PER_CPU to be NR_VECTORS
2009-01-12 19:54 [PATCH] x86: make 32bit MAX_HARDIRQSS_PER_CPU to be NR_VECTORS Yinghai Lu
@ 2009-01-14 11:17 ` Ingo Molnar
2009-01-14 21:38 ` Yinghai Lu
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2009-01-14 11:17 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Thomas Gleixner, H. Peter Anvin, linux-kernel@vger.kernel.org
* Yinghai Lu <yinghai@kernel.org> wrote:
> Impact: clean up to be same as 64bit
>
> 32bit is use per-cpu vector too, so don't use default NR_IRQS
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> ---
> arch/x86/include/asm/hardirq_32.h | 3 +++
> arch/x86/include/asm/irq_vectors.h | 4 ++--
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/arch/x86/include/asm/hardirq_32.h
> ===================================================================
> --- linux-2.6.orig/arch/x86/include/asm/hardirq_32.h
> +++ linux-2.6/arch/x86/include/asm/hardirq_32.h
> @@ -20,6 +20,9 @@ typedef struct {
>
> DECLARE_PER_CPU(irq_cpustat_t, irq_stat);
>
> +/* We can have at most NR_VECTORS irqs routed to a cpu at a time */
> +#define MAX_HARDIRQS_PER_CPU NR_VECTORS
> +
> #define __ARCH_IRQ_STAT
> #define __IRQ_STAT(cpu, member) (per_cpu(irq_stat, cpu).member)
applied to tip/x86/cleanups. Btw., isnt the irq_vectors.h bit (mentioned
in the diffstat) missing?
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: make 32bit MAX_HARDIRQSS_PER_CPU to be NR_VECTORS
2009-01-14 11:17 ` Ingo Molnar
@ 2009-01-14 21:38 ` Yinghai Lu
0 siblings, 0 replies; 3+ messages in thread
From: Yinghai Lu @ 2009-01-14 21:38 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Thomas Gleixner, H. Peter Anvin, linux-kernel@vger.kernel.org
On Wed, Jan 14, 2009 at 3:17 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Yinghai Lu <yinghai@kernel.org> wrote:
>
>> Impact: clean up to be same as 64bit
>>
>> 32bit is use per-cpu vector too, so don't use default NR_IRQS
>>
>> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>>
>> ---
>> arch/x86/include/asm/hardirq_32.h | 3 +++
>> arch/x86/include/asm/irq_vectors.h | 4 ++--
>> 2 files changed, 5 insertions(+), 2 deletions(-)
>>
>> Index: linux-2.6/arch/x86/include/asm/hardirq_32.h
>> ===================================================================
>> --- linux-2.6.orig/arch/x86/include/asm/hardirq_32.h
>> +++ linux-2.6/arch/x86/include/asm/hardirq_32.h
>> @@ -20,6 +20,9 @@ typedef struct {
>>
>> DECLARE_PER_CPU(irq_cpustat_t, irq_stat);
>>
>> +/* We can have at most NR_VECTORS irqs routed to a cpu at a time */
>> +#define MAX_HARDIRQS_PER_CPU NR_VECTORS
>> +
>> #define __ARCH_IRQ_STAT
>> #define __IRQ_STAT(cpu, member) (per_cpu(irq_stat, cpu).member)
>
> applied to tip/x86/cleanups. Btw., isnt the irq_vectors.h bit (mentioned
> in the diffstat) missing?
>
copy and modify the patch
forget to do quilt refresh --diffstat
YH
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-14 21:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-12 19:54 [PATCH] x86: make 32bit MAX_HARDIRQSS_PER_CPU to be NR_VECTORS Yinghai Lu
2009-01-14 11:17 ` Ingo Molnar
2009-01-14 21:38 ` Yinghai Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox