public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: pageexec@freemail.hu
To: Suresh Siddha <suresh.b.siddha@intel.com>, Ingo Molnar <mingo@elte.hu>
Cc: hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org,
	venkatesh.pallipadi@intel.com, Daniel.Beschorner@facton.com,
	stable@kernel.org
Subject: Re: [patch] x86: fix PTE corruption issue while mapping RAM using /dev/mem
Date: Tue, 13 Jan 2009 01:19:09 +0200	[thread overview]
Message-ID: <496BDDFD.27997.A74B06@pageexec.freemail.hu> (raw)
In-Reply-To: <20090112235135.GA22722@elte.hu>

On 13 Jan 2009 at 0:51, Ingo Molnar wrote:

> applied to tip/x86/urgent, thanks Suresh!
> 
> note that the patch caused some conflicts (there were other changes in 
> pat.c) - i merged it up manually but could you please check the final 
> commit in tip/master whether it's all OK?

i don't think that it got applied properly:

diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index 85cbd3c..ea36ed7 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -347,9 +347,6 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
        new->end        = end;
        new->type       = actual_type;

-       if (new_type)
-               *new_type = actual_type;
-
        spin_lock(&memtype_lock);

        if (cached_entry && start >= cached_start)
@@ -437,6 +434,9 @@ int free_memtype(u64 start, u64 end)
        if (is_ISA_range(start, end - 1))
                return 0;

+       if (new_type)
+               *new_type = actual_type;
+
        is_range_ram = pagerange_is_ram(start, end);
        if (is_range_ram == 1)
                return free_ram_pages_type(start, end);

free_memtype doesn't even have a new_type argument for starters ;), patch
must have applied it at the wrong place...


  reply	other threads:[~2009-01-13  0:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-12 20:31 [patch] x86: fix PTE corruption issue while mapping RAM using /dev/mem Suresh Siddha
2009-01-12 23:51 ` Ingo Molnar
2009-01-12 23:19   ` pageexec [this message]
2009-01-13  0:31     ` Ingo Molnar
2009-01-13 18:21       ` Suresh Siddha
2009-01-21 17:42         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496BDDFD.27997.A74B06@pageexec.freemail.hu \
    --to=pageexec@freemail.hu \
    --cc=Daniel.Beschorner@facton.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox