From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>
Cc: joe.tian.kernel@gmail.com, lizf@cn.fujitsu.com,
qhfeng.kernel@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NET: fix wrong English expression in comments
Date: Tue, 13 Jan 2009 08:57:59 +0100 [thread overview]
Message-ID: <496C4987.8040803@cosmosbay.com> (raw)
In-Reply-To: <20090112.234441.131571840.davem@davemloft.net>
David Miller a écrit :
> From: joe tian <joe.tian.kernel@gmail.com>
> Date: Tue, 13 Jan 2009 15:36:51 +0800
>
>> 2009/1/12 Li Zefan <lizf@cn.fujitsu.com>:
>>>> @@ -103,7 +103,7 @@ struct inet_bind_bucket;
>>>> struct inet_timewait_sock {
>>>> /*
>>>> * Now struct sock also uses sock_common, so please just
>>>> - * don't add nothing before this first member (__tw_common) --acme
>>>> + * don't add anything before this first member (__tw_common) --acme
>>> They are the same meaning...
>>>
>> I don't think they are the same meaning.
>> I think "don't add anything" means "do add nothing" but not means "don't add
>> nothing"
>
> No offense to anyone, but the only people arguing for "correctness"
> seem to be non-native speakers of English. Is this correct? :-)
>
> As Ben tries to explain, "don't add nothing" is a colloquialism of
> English that in fact can mean "do not add"
>
> It sounds amusing when read, and I'm not killing the character and
> personality of this comment just for some language lawyering.
>
> No way.
Oh my God... time for me to check what is a colloquialism :)
According to wikipedia :
A colloquialism is an expression not used in formal speech,
writing or paralinguistics. Colloquialisms are also sometimes
referred to collectively as "colloquial language". [1] Colloquialisms
or colloquial language is considered to be characteristic of or only
appropriate for casual, ordinary, familiar, or informal conversation
rather than formal speech or writing.[2] Dictionaries often display
colloquial words and phrases with the abbreviation colloq. as an identifier.
Ouch... back to coding :)
next prev parent reply other threads:[~2009-01-13 7:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 18:36 [PATCH] NET: fix wrong English expression in comments Qinghuang Feng
2009-01-12 1:05 ` Li Zefan
2009-01-12 1:39 ` Ben Hutchings
2009-01-13 5:53 ` David Miller
2009-01-13 6:16 ` Daolong Wang
2009-01-13 8:41 ` David Newall
2009-01-13 9:04 ` Alan Cox
2009-01-13 12:09 ` David Newall
2009-01-13 23:22 ` Valdis.Kletnieks
2009-01-13 23:30 ` Randy Dunlap
[not found] ` <6b1ba94c0901122336r511fa316o5f520a8d2d9d6e0@mail.gmail.com>
2009-01-13 7:44 ` David Miller
2009-01-13 7:56 ` Li Zefan
2009-01-13 7:57 ` Eric Dumazet [this message]
2009-01-13 8:52 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496C4987.8040803@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=joe.tian.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=qhfeng.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox