* [PATCH v2] memcg: fix section mismatch
@ 2009-01-14 7:04 Li Zefan
2009-01-14 7:07 ` KAMEZAWA Hiroyuki
0 siblings, 1 reply; 3+ messages in thread
From: Li Zefan @ 2009-01-14 7:04 UTC (permalink / raw)
To: Andrew Morton; +Cc: KAMEZAWA Hiroyuki, Balbir Singh, Rakib Mullick, LKML
At system boot when creating the top cgroup, mem_cgroup_create() calls
enable_swap_cgroup() which is marked as __init, so mark mem_cgroup_create()
as __ref to avoid false section mismatch warning.
Reported-by: Rakib Mullick <rakib.mullick@gmail.com>
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
use __ref instead of __init_refok
---
mm/memcontrol.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index e2996b8..e57afca 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2181,7 +2181,7 @@ static void __init enable_swap_cgroup(void)
}
#endif
-static struct cgroup_subsys_state *
+static struct cgroup_subsys_state * __ref
mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont)
{
struct mem_cgroup *mem, *parent;
--
1.5.4.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] memcg: fix section mismatch
2009-01-14 7:04 [PATCH v2] memcg: fix section mismatch Li Zefan
@ 2009-01-14 7:07 ` KAMEZAWA Hiroyuki
2009-01-14 7:12 ` Li Zefan
0 siblings, 1 reply; 3+ messages in thread
From: KAMEZAWA Hiroyuki @ 2009-01-14 7:07 UTC (permalink / raw)
To: Li Zefan; +Cc: Andrew Morton, Balbir Singh, Rakib Mullick, LKML
On Wed, 14 Jan 2009 15:04:32 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> At system boot when creating the top cgroup, mem_cgroup_create() calls
> enable_swap_cgroup() which is marked as __init, so mark mem_cgroup_create()
> as __ref to avoid false section mismatch warning.
>
> Reported-by: Rakib Mullick <rakib.mullick@gmail.com>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by; KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> ---
>
> use __ref instead of __init_refok
>
change log ?
> ---
> mm/memcontrol.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index e2996b8..e57afca 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2181,7 +2181,7 @@ static void __init enable_swap_cgroup(void)
> }
> #endif
>
> -static struct cgroup_subsys_state *
> +static struct cgroup_subsys_state * __ref
> mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont)
> {
> struct mem_cgroup *mem, *parent;
> --
> 1.5.4.rc3
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] memcg: fix section mismatch
2009-01-14 7:07 ` KAMEZAWA Hiroyuki
@ 2009-01-14 7:12 ` Li Zefan
0 siblings, 0 replies; 3+ messages in thread
From: Li Zefan @ 2009-01-14 7:12 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki; +Cc: Andrew Morton, Balbir Singh, Rakib Mullick, LKML
KAMEZAWA Hiroyuki wrote:
> On Wed, 14 Jan 2009 15:04:32 +0800
> Li Zefan <lizf@cn.fujitsu.com> wrote:
>
>> At system boot when creating the top cgroup, mem_cgroup_create() calls
>> enable_swap_cgroup() which is marked as __init, so mark mem_cgroup_create()
>> as __ref to avoid false section mismatch warning.
>>
>> Reported-by: Rakib Mullick <rakib.mullick@gmail.com>
>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
>
> Acked-by; KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
>> ---
>>
>> use __ref instead of __init_refok
>>
> change log ?
>
Yes. But for this simple patch, I don't think change log for v1 -> v2 is worth
anything for the normal changelog. :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-14 7:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-14 7:04 [PATCH v2] memcg: fix section mismatch Li Zefan
2009-01-14 7:07 ` KAMEZAWA Hiroyuki
2009-01-14 7:12 ` Li Zefan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox