Re: [PATCH] module: kzalloc mod->ref

Ingo Molnar
2009-01-27T13:16:17Z

* Rusty Russell <rusty@rustcorp.com.au> wrote:

> @@ -344,8 +339,11 @@ struct module
> /* Destruction function. */
> void (*exit)(void);
>
> - /* Reference counts */
> - struct module_ref ref[NR_CPUS];
> +#ifdef CONFIG_SMP
> + char *refptr;
> +#else
> + local_t ref;
> +#endif

hm, that construct looks rather ugly. Is there no way to provide a clean
data type and APIs for this that just work symmetrically on both SMP and
UP?

Ingo