Re: [PATCH] module: kzalloc mod->ref

Kyle McMartin
2009-01-14T20:54:18Z

On Wed, Jan 14, 2009 at 09:37:18PM +0100, Takashi Iwai wrote:
> At Wed, 14 Jan 2009 14:29:08 -0500,
> Valdis.Kletnieks@vt.edu wrote:
> >
> > On Wed, 14 Jan 2009 17:25:31 +0100, Takashi Iwai said:
> >
> > > We can use nr_cpu_ids instead of NR_CPUS.
> > > For a machine like 4096 CPUs, such an amount of memory is like a
> > > peanut :)
> >
> > It's not peanuts if you're dealing with a distro kernel that's essentially
> > forced to compile with NR_CPUS=<some moby integer>, but booting on a single or
> > dual core system with possibly not even 1G of memory.
>
> My suggestion above is to use nr_cpu_ids, which is the actual number
> of CPUs, not a constant like NR_CPUS.
>

Yes, I agree that it's a better solution, since I suppose it's based on
cpu_possible_mask as opposed to, well, the maximum possible.

I'll fire off an updated patch. Let's see what rusty thinks.

cheers, Kyle