* [PATCH] usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28
@ 2009-01-13 17:36 Jiří Burda
2009-01-13 23:37 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Jiří Burda @ 2009-01-13 17:36 UTC (permalink / raw)
To: linux-usb, greg, akpm; +Cc: linux-kernel
From: Jiri Burda <jburda@email.cz>
Nokia 5310 mobile with firmware revision 8.32 does not mount as usb mass-storage in kernel 2.6.28 and previous.
This patch solves this problem by increasing firmware revision in drivers/usb/storage/unusual_device.h from 0x0701 to 0x0832.
This bug is recorded in kernel bugzilla as 12367.
Signed-off-by: Jiri Burda <jburda@email.cz>
---
--- linux-2.6.28/drivers/usb/storage/unusual_devs.h.orig 2009-01-13 17:21:24.000000000 +0100
+++ linux-2.6.28/drivers/usb/storage/unusual_devs.h 2009-01-13 19:24:16.000000000 +0100
@@ -182,7 +182,7 @@ UNUSUAL_DEV( 0x0421, 0x0063, 0x0001, 0x
US_FL_FIX_CAPACITY ),
/* Patch for Nokia 5310 capacity */
-UNUSUAL_DEV( 0x0421, 0x006a, 0x0000, 0x0701,
+UNUSUAL_DEV( 0x0421, 0x006a, 0x0000, 0x0832,
"Nokia",
"5310",
US_SC_DEVICE, US_PR_DEVICE, NULL,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28
2009-01-13 17:36 [PATCH] usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28 Jiří Burda
@ 2009-01-13 23:37 ` Andrew Morton
2009-01-13 23:46 ` Greg KH
2009-01-14 14:57 ` Alan Stern
0 siblings, 2 replies; 6+ messages in thread
From: Andrew Morton @ 2009-01-13 23:37 UTC (permalink / raw)
To: Ji__í Burda; +Cc: linux-usb, greg, linux-kernel
On Tue, 13 Jan 2009 18:36:20 +0100
Ji____ Burda <jburda@email.cz> wrote:
> From: Jiri Burda <jburda@email.cz>
>
> Nokia 5310 mobile with firmware revision 8.32 does not mount as usb mass-storage in kernel 2.6.28 and previous.
> This patch solves this problem by increasing firmware revision in drivers/usb/storage/unusual_device.h from 0x0701 to 0x0832.
> This bug is recorded in kernel bugzilla as 12367.
> Signed-off-by: Jiri Burda <jburda@email.cz>
> ---
> --- linux-2.6.28/drivers/usb/storage/unusual_devs.h.orig 2009-01-13 17:21:24.000000000 +0100
> +++ linux-2.6.28/drivers/usb/storage/unusual_devs.h 2009-01-13 19:24:16.000000000 +0100
> @@ -182,7 +182,7 @@ UNUSUAL_DEV( 0x0421, 0x0063, 0x0001, 0x
> US_FL_FIX_CAPACITY ),
>
> /* Patch for Nokia 5310 capacity */
> -UNUSUAL_DEV( 0x0421, 0x006a, 0x0000, 0x0701,
> +UNUSUAL_DEV( 0x0421, 0x006a, 0x0000, 0x0832,
> "Nokia",
> "5310",
> US_SC_DEVICE, US_PR_DEVICE, NULL,
>
akpm:/usr/src/25> grep 5310 drivers/usb/storage/unusual_devs.h
akpm:/usr/src/25>
The 5310 entry seems to have been removed in 2.6.29-rc1.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28
2009-01-13 23:37 ` Andrew Morton
@ 2009-01-13 23:46 ` Greg KH
2009-01-14 14:57 ` Alan Stern
1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2009-01-13 23:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: Ji__í Burda, linux-usb, linux-kernel
On Tue, Jan 13, 2009 at 03:37:04PM -0800, Andrew Morton wrote:
> On Tue, 13 Jan 2009 18:36:20 +0100
> Ji____ Burda <jburda@email.cz> wrote:
>
> > From: Jiri Burda <jburda@email.cz>
> >
> > Nokia 5310 mobile with firmware revision 8.32 does not mount as usb mass-storage in kernel 2.6.28 and previous.
> > This patch solves this problem by increasing firmware revision in drivers/usb/storage/unusual_device.h from 0x0701 to 0x0832.
> > This bug is recorded in kernel bugzilla as 12367.
> > Signed-off-by: Jiri Burda <jburda@email.cz>
> > ---
> > --- linux-2.6.28/drivers/usb/storage/unusual_devs.h.orig 2009-01-13 17:21:24.000000000 +0100
> > +++ linux-2.6.28/drivers/usb/storage/unusual_devs.h 2009-01-13 19:24:16.000000000 +0100
> > @@ -182,7 +182,7 @@ UNUSUAL_DEV( 0x0421, 0x0063, 0x0001, 0x
> > US_FL_FIX_CAPACITY ),
> >
> > /* Patch for Nokia 5310 capacity */
> > -UNUSUAL_DEV( 0x0421, 0x006a, 0x0000, 0x0701,
> > +UNUSUAL_DEV( 0x0421, 0x006a, 0x0000, 0x0832,
> > "Nokia",
> > "5310",
> > US_SC_DEVICE, US_PR_DEVICE, NULL,
> >
>
> akpm:/usr/src/25> grep 5310 drivers/usb/storage/unusual_devs.h
> akpm:/usr/src/25>
>
> The 5310 entry seems to have been removed in 2.6.29-rc1.
Yes, we are handling all Nokia devices in a generic way now in 2.6.29,
so patches like this should no longer be needed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28
2009-01-13 23:37 ` Andrew Morton
2009-01-13 23:46 ` Greg KH
@ 2009-01-14 14:57 ` Alan Stern
2009-01-14 23:26 ` Jir(í Burda
1 sibling, 1 reply; 6+ messages in thread
From: Alan Stern @ 2009-01-14 14:57 UTC (permalink / raw)
To: Andrew Morton; +Cc: Ji__í Burda, linux-usb, greg, linux-kernel
On Tue, 13 Jan 2009, Andrew Morton wrote:
> > From: Jiri Burda <jburda@email.cz>
> >
> > Nokia 5310 mobile with firmware revision 8.32 does not mount as usb mass-storage in kernel 2.6.28 and previous.
> > This patch solves this problem by increasing firmware revision in drivers/usb/storage/unusual_device.h from 0x0701 to 0x0832.
> > This bug is recorded in kernel bugzilla as 12367.
> The 5310 entry seems to have been removed in 2.6.29-rc1.
Indeed, as Greg mentioned we are now using a generic scheme for Nokia
devices.
Jiri, can you try running 2.6.29-rc1 to see whether it's okay already?
Alan Stern
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28
2009-01-14 14:57 ` Alan Stern
@ 2009-01-14 23:26 ` Jir(í Burda
2009-01-15 15:14 ` Alan Stern
0 siblings, 1 reply; 6+ messages in thread
From: Jir(í Burda @ 2009-01-14 23:26 UTC (permalink / raw)
To: Alan Stern; +Cc: Andrew Morton, linux-usb, greg, linux-kernel
Alan,
I can confirm Nokia 5310 with firmware 8.32 mounts correctly in 2.6.29-rc1.
Jiri Burda
Alan Stern napsal(a):
> On Tue, 13 Jan 2009, Andrew Morton wrote:
>
>>> From: Jiri Burda <jburda@email.cz>
>>>
>>> Nokia 5310 mobile with firmware revision 8.32 does not mount as usb mass-storage in kernel 2.6.28 and previous.
>>> This patch solves this problem by increasing firmware revision in drivers/usb/storage/unusual_device.h from 0x0701 to 0x0832.
>>> This bug is recorded in kernel bugzilla as 12367.
>
>> The 5310 entry seems to have been removed in 2.6.29-rc1.
>
> Indeed, as Greg mentioned we are now using a generic scheme for Nokia
> devices.
>
> Jiri, can you try running 2.6.29-rc1 to see whether it's okay already?
>
> Alan Stern
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28
2009-01-14 23:26 ` Jir(í Burda
@ 2009-01-15 15:14 ` Alan Stern
0 siblings, 0 replies; 6+ messages in thread
From: Alan Stern @ 2009-01-15 15:14 UTC (permalink / raw)
To: Jir(í Burda; +Cc: Andrew Morton, linux-usb, greg, linux-kernel
On Thu, 15 Jan 2009, [windows-1252] Jir(í Burda wrote:
> Alan,
>
> I can confirm Nokia 5310 with firmware 8.32 mounts correctly in 2.6.29-rc1.
Thanks for testing. So your patch will be needed only for
2.6.28.stable and earlier kernels.
Alan Stern
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-01-15 15:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-13 17:36 [PATCH] usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28 Jiří Burda
2009-01-13 23:37 ` Andrew Morton
2009-01-13 23:46 ` Greg KH
2009-01-14 14:57 ` Alan Stern
2009-01-14 23:26 ` Jir(í Burda
2009-01-15 15:14 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox