* CONFIG_MFD_PCF50633=m breaks the kernel build @ 2009-01-15 9:06 Jean Delvare 2009-01-15 9:11 ` Balaji Rao 0 siblings, 1 reply; 7+ messages in thread From: Jean Delvare @ 2009-01-15 9:06 UTC (permalink / raw) To: Balaji Rao, LKML Hi Balaji, Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m fails at linking time with: ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined! ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined! -- Jean Delvare ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: CONFIG_MFD_PCF50633=m breaks the kernel build 2009-01-15 9:06 CONFIG_MFD_PCF50633=m breaks the kernel build Jean Delvare @ 2009-01-15 9:11 ` Balaji Rao 2009-01-15 10:09 ` Jean Delvare 0 siblings, 1 reply; 7+ messages in thread From: Balaji Rao @ 2009-01-15 9:11 UTC (permalink / raw) To: Jean Delvare; +Cc: LKML On Thu, Jan 15, 2009 at 10:06:53AM +0100, Jean Delvare wrote: > Hi Balaji, > > Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m > fails at linking time with: > > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined! > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined! Yes, I've seen this. The fix is waiting on linux-mfd to be pulled anytime soon. Thanks, Balaji ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: CONFIG_MFD_PCF50633=m breaks the kernel build 2009-01-15 9:11 ` Balaji Rao @ 2009-01-15 10:09 ` Jean Delvare 2009-01-15 10:31 ` Balaji Rao 2009-01-15 10:33 ` Adrian-Ken Rueegsegger 0 siblings, 2 replies; 7+ messages in thread From: Jean Delvare @ 2009-01-15 10:09 UTC (permalink / raw) To: Balaji Rao; +Cc: LKML On Thu, 15 Jan 2009 14:41:08 +0530, Balaji Rao wrote: > On Thu, Jan 15, 2009 at 10:06:53AM +0100, Jean Delvare wrote: > > Hi Balaji, > > > > Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m > > fails at linking time with: > > > > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined! > > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined! > > Yes, I've seen this. The fix is waiting on linux-mfd to be pulled > anytime soon. Where is linux-mfd? And what is it, a git tree, a mailing list? I couldn't find any reference. Can you please send me the patch now, so that I can fix my build locally right now? Thanks, -- Jean Delvare ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: CONFIG_MFD_PCF50633=m breaks the kernel build 2009-01-15 10:09 ` Jean Delvare @ 2009-01-15 10:31 ` Balaji Rao 2009-01-15 11:00 ` Jean Delvare 2009-01-15 10:33 ` Adrian-Ken Rueegsegger 1 sibling, 1 reply; 7+ messages in thread From: Balaji Rao @ 2009-01-15 10:31 UTC (permalink / raw) To: Jean Delvare; +Cc: LKML On Thu, Jan 15, 2009 at 11:09:55AM +0100, Jean Delvare wrote: > On Thu, 15 Jan 2009 14:41:08 +0530, Balaji Rao wrote: > > On Thu, Jan 15, 2009 at 10:06:53AM +0100, Jean Delvare wrote: > > > Hi Balaji, > > > > > > Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m > > > fails at linking time with: > > > > > > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined! > > > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined! > > > > Yes, I've seen this. The fix is waiting on linux-mfd to be pulled > > anytime soon. > > Where is linux-mfd? And what is it, a git tree, a mailing list? I > couldn't find any reference. It's a git tree at http://git.o-hand.com/cgit.cgi/linux-mfd/ > > Can you please send me the patch now, so that I can fix my build > locally right now? > pcf50633: Remove references to non-exported functions Remove references to set_irq_type and handle_level_irq which are not exported to modules. Signed-off-by: Balaji Rao <balajirrao@openmoko.org> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c index 24508e2..ea9488e 100644 --- a/drivers/mfd/pcf50633-core.c +++ b/drivers/mfd/pcf50633-core.c @@ -626,7 +626,6 @@ static int __devinit pcf50633_probe(struct i2c_client *client, } if (client->irq) { - set_irq_handler(client->irq, handle_level_irq); ret = request_irq(client->irq, pcf50633_irq, IRQF_TRIGGER_LOW, "pcf50633", pcf); ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: CONFIG_MFD_PCF50633=m breaks the kernel build 2009-01-15 10:31 ` Balaji Rao @ 2009-01-15 11:00 ` Jean Delvare 2009-01-15 11:17 ` Balaji Rao 0 siblings, 1 reply; 7+ messages in thread From: Jean Delvare @ 2009-01-15 11:00 UTC (permalink / raw) To: Balaji Rao; +Cc: LKML On Thu, 15 Jan 2009 16:01:13 +0530, Balaji Rao wrote: > On Thu, Jan 15, 2009 at 11:09:55AM +0100, Jean Delvare wrote: > > On Thu, 15 Jan 2009 14:41:08 +0530, Balaji Rao wrote: > > > On Thu, Jan 15, 2009 at 10:06:53AM +0100, Jean Delvare wrote: > > > > Hi Balaji, > > > > > > > > Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m > > > > fails at linking time with: > > > > > > > > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined! > > > > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined! > > > > > > Yes, I've seen this. The fix is waiting on linux-mfd to be pulled > > > anytime soon. > > > > Where is linux-mfd? And what is it, a git tree, a mailing list? I > > couldn't find any reference. > > It's a git tree at http://git.o-hand.com/cgit.cgi/linux-mfd/ Would you be so kind and write a patch adding this information to MAINTAINERS? And get it upstream, so that developers know where it is. > > Can you please send me the patch now, so that I can fix my build > > locally right now? > > pcf50633: Remove references to non-exported functions > > Remove references to set_irq_type and handle_level_irq which are not > exported to modules. > > Signed-off-by: Balaji Rao <balajirrao@openmoko.org> > > diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c > index 24508e2..ea9488e 100644 > --- a/drivers/mfd/pcf50633-core.c > +++ b/drivers/mfd/pcf50633-core.c > @@ -626,7 +626,6 @@ static int __devinit pcf50633_probe(struct i2c_client *client, > } > > if (client->irq) { > - set_irq_handler(client->irq, handle_level_irq); > ret = request_irq(client->irq, pcf50633_irq, > IRQF_TRIGGER_LOW, "pcf50633", pcf); > Great, thanks! Now I can go on with my work. -- Jean Delvare ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: CONFIG_MFD_PCF50633=m breaks the kernel build 2009-01-15 11:00 ` Jean Delvare @ 2009-01-15 11:17 ` Balaji Rao 0 siblings, 0 replies; 7+ messages in thread From: Balaji Rao @ 2009-01-15 11:17 UTC (permalink / raw) To: Jean Delvare; +Cc: LKML On Thu, Jan 15, 2009 at 12:00:25PM +0100, Jean Delvare wrote: > On Thu, 15 Jan 2009 16:01:13 +0530, Balaji Rao wrote: > > On Thu, Jan 15, 2009 at 11:09:55AM +0100, Jean Delvare wrote: > > > On Thu, 15 Jan 2009 14:41:08 +0530, Balaji Rao wrote: > > > > On Thu, Jan 15, 2009 at 10:06:53AM +0100, Jean Delvare wrote: > > > > > Hi Balaji, > > > > > > > > > > Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m > > > > > fails at linking time with: > > > > > > > > > > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined! > > > > > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined! > > > > > > > > Yes, I've seen this. The fix is waiting on linux-mfd to be pulled > > > > anytime soon. > > > > > > Where is linux-mfd? And what is it, a git tree, a mailing list? I > > > couldn't find any reference. > > > > It's a git tree at http://git.o-hand.com/cgit.cgi/linux-mfd/ > > Would you be so kind and write a patch adding this information to > MAINTAINERS? And get it upstream, so that developers know where it is. > Yes, that's a good idea. Will do. - Balaji ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: CONFIG_MFD_PCF50633=m breaks the kernel build 2009-01-15 10:09 ` Jean Delvare 2009-01-15 10:31 ` Balaji Rao @ 2009-01-15 10:33 ` Adrian-Ken Rueegsegger 1 sibling, 0 replies; 7+ messages in thread From: Adrian-Ken Rueegsegger @ 2009-01-15 10:33 UTC (permalink / raw) To: Jean Delvare; +Cc: Balaji Rao, LKML Jean Delvare wrote: > On Thu, 15 Jan 2009 14:41:08 +0530, Balaji Rao wrote: >> On Thu, Jan 15, 2009 at 10:06:53AM +0100, Jean Delvare wrote: >>> Hi Balaji, >>> >>> Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m >>> fails at linking time with: >>> >>> ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined! >>> ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined! >> Yes, I've seen this. The fix is waiting on linux-mfd to be pulled >> anytime soon. > > Where is linux-mfd? And what is it, a git tree, a mailing list? I > couldn't find any reference. git://git.o-hand.com/linux-mfd > Can you please send me the patch now, so that I can fix my build > locally right now? The related commit: http://git.o-hand.com/cgit.cgi/linux-mfd/commit/?h=for-linus&id=9bf04a9690b3c961150ac508d343c875f0d641ad Adrian ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-01-15 11:18 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-01-15 9:06 CONFIG_MFD_PCF50633=m breaks the kernel build Jean Delvare 2009-01-15 9:11 ` Balaji Rao 2009-01-15 10:09 ` Jean Delvare 2009-01-15 10:31 ` Balaji Rao 2009-01-15 11:00 ` Jean Delvare 2009-01-15 11:17 ` Balaji Rao 2009-01-15 10:33 ` Adrian-Ken Rueegsegger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox