From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764470AbZAOLOa (ORCPT ); Thu, 15 Jan 2009 06:14:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759978AbZAOLOV (ORCPT ); Thu, 15 Jan 2009 06:14:21 -0500 Received: from ppsw-0.csi.cam.ac.uk ([131.111.8.130]:34219 "EHLO ppsw-0.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759901AbZAOLOU (ORCPT ); Thu, 15 Jan 2009 06:14:20 -0500 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Message-ID: <496F1A85.6030304@gmail.com> Date: Thu, 15 Jan 2009 11:14:13 +0000 From: Jonathan Cameron User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Mike Rapoport CC: Jonathan Cameron , LKML , Mark Brown , Samuel Ortiz , eric miao , felipe.balbi@nokia.com, Liam Girdwood Subject: Re: [PATCH 2.6.29-rc1-git4] mfd: da9030 usb charge pump support within mfd driver. References: <496E2BE5.1050803@cam.ac.uk> <496ED9EF.2050507@compulab.co.il> In-Reply-To: <496ED9EF.2050507@compulab.co.il> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mike Rapoport wrote: > Jonathan, > Below are my two cents :) Thanks. > Jonathan Cameron wrote: >> From: Jonathan Cameron >> >> Add support for changing the mode of the da9030 usb charge pump >> >> Signed-off-by: Jonathan Cameron >> >> --- >> >> Minor changes from previous version to reflect changes in the >> driver being patched. Addtional cc's as per Mark's suggestion. >> >> This version simply adds the functionality to the da903x mfd driver >> core. If anyone can suggest a way round simply maintaining a >> global pointer to the device it would be good. > > I don't think the global pointer here is real problem. It should be *really* > weird design with two da903x. Would be 'unusual'! >> To be able to call this from a board config file the driver must be >> built in rather than a module but enforcing that is down to the >> board Kconfig entry. > > Most probably the board with da9030 will anyway have it built-in... Agreed. >> +EXPORT_SYMBOL_GPL(da9030_set_usb_charge_pump_mode); >> + > > Maybe we want to have 'da9030_set_usb_charge_pump_mode' as well? (get?) Possibly, though only purpose I can think of for this would be debugging and from the datasheet I can't see any case under which the set can fail?