linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: crash: IP: [<ffffffff80478092>] __bitmap_intersects+0x48/0x73 [PATCH supplied]
Date: Thu, 15 Jan 2009 09:30:01 -0800	[thread overview]
Message-ID: <496F7299.3060900@sgi.com> (raw)
In-Reply-To: <20090115122156.GA20349@elte.hu>

Ingo Molnar wrote:
> FYI, there's new warnings due to cpumask changes:
> 
> arch/x86/kernel/cpu/intel_cacheinfo.c: In function ‘show_cache_disable’:
> arch/x86/kernel/cpu/intel_cacheinfo.c:710: warning: unused variable ‘mask’
> arch/x86/kernel/cpu/intel_cacheinfo.c: In function ‘store_cache_disable’:
> arch/x86/kernel/cpu/intel_cacheinfo.c:745: warning: unused variable ‘mask’
> 
> on 32-bit defconfig.
> 
> 	Ingo

Hi Ingo,

You can pull the following patch to fix this build warning.

Thanks!
Mike
--- 

The following changes since commit e46d51787e23a607cac5f593ac9926743a636dff:
  Ingo Molnar (1):
        Merge branch 'master' of ssh://master.kernel.org/.../travis/linux-2.6-cpus4096-for-ingo into cpus4096

are available in the git repository at:

  ssh://master.kernel.org/pub/scm/linux/kernel/git/travis/linux-2.6-cpus4096-for-ingo master

Mike Travis (1):
      x86: fix build warning when CONFIG_NUMA not defined.

 arch/x86/include/asm/topology.h |   17 ++++++++++++++---
 1 files changed, 14 insertions(+), 3 deletions(-)

commit f2a082711905312dc7b6675e913fee0c4689f7ae
Author: Mike Travis <travis@sgi.com>
Date:   Thu Jan 15 09:19:32 2009 -0800

    x86: fix build warning when CONFIG_NUMA not defined.
    
    Impact: fix build warning
    
    The macro cpu_to_node did not reference it's argument, and instead
    simply returned a 0.  This causes a "unused variable" warning if
    it's the only reference in a function (show_cache_disable).
    
    Replace it with the more correct inline function.
    
    Signed-off-by: Mike Travis <travis@sgi.com>

diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h
index 4e2f2e0..d0c68e2 100644
--- a/arch/x86/include/asm/topology.h
+++ b/arch/x86/include/asm/topology.h
@@ -192,9 +192,20 @@ extern int __node_distance(int, int);
 
 #else /* !CONFIG_NUMA */
 
-#define numa_node_id()		0
-#define	cpu_to_node(cpu)	0
-#define	early_cpu_to_node(cpu)	0
+static inline int numa_node_id(void)
+{
+	return 0;
+}
+
+static inline int cpu_to_node(int cpu)
+{
+	return 0;
+}
+
+static inline int early_cpu_to_node(int cpu)
+{
+	return 0;
+}
 
 static inline const cpumask_t *cpumask_of_node(int node)
 {

  reply	other threads:[~2009-01-15 17:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <496BF6D5.9030403@sgi.com>
     [not found] ` <20090113130048.GB31147@elte.hu>
     [not found]   ` <496CAF5A.3010304@sgi.com>
     [not found]     ` <496D0F46.2010907@sgi.com>
     [not found]       ` <496D2172.6030608@sgi.com>
     [not found]         ` <20090114165431.GA18826@elte.hu>
     [not found]           ` <20090114165524.GA21742@elte.hu>
     [not found]             ` <20090114175126.GA21078@elte.hu>
2009-01-14 23:43               ` crash: IP: [<ffffffff80478092>] __bitmap_intersects+0x48/0x73 [PATCH supplied] Mike Travis
2009-01-15 10:14                 ` Ingo Molnar
2009-01-15 16:44                   ` Mike Travis
2009-01-15 17:35                     ` Ingo Molnar
2009-01-15 17:59                     ` Andreas Schwab
2009-01-15 20:34                       ` Mike Travis
2009-01-16  9:44                         ` Andreas Schwab
2009-01-15 10:16                 ` Ingo Molnar
2009-01-15 12:21                   ` Ingo Molnar
2009-01-15 17:30                     ` Mike Travis [this message]
2009-01-15 17:37                       ` Ingo Molnar
2009-01-15 16:46                   ` Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496F7299.3060900@sgi.com \
    --to=travis@sgi.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).