From: Michael Roth <mroth@nessie.de>
To: linux-kernel@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, imre.deak@nokia.com
Subject: [PATCH] ads7846: Pin change interrupt support
Date: Sat, 17 Jan 2009 01:06:09 +0100 [thread overview]
Message-ID: <497120F1.7020409@nessie.de> (raw)
Some SoC supports only pin change interrupts on GPIO pins
used as irq lines.
The ads7846 core is not affected from the additional irqs
on the rising edge because the code accounts touch bounce
anyway by kicking in a timer and disabling the irq after
the first request and reenabling the irq after a timeout
when there is no longer pen down detected.
Signed-off-by: Michael Roth <mroth@nessie.de>
---
diff -ur linux-2.6.28/drivers/input/touchscreen/ads7846.c linux-2.6.28-work/drivers/input/touchscreen/ads7846.c
--- linux-2.6.28/drivers/input/touchscreen/ads7846.c 2008-12-25 00:26:37.000000000 +0100
+++ linux-2.6.28-work/drivers/input/touchscreen/ads7846.c 2009-01-17 00:40:15.000000000 +0100
@@ -1131,9 +1131,14 @@
if (request_irq(spi->irq, ads7846_irq, IRQF_TRIGGER_FALLING,
spi->dev.driver->name, ts)) {
- dev_dbg(&spi->dev, "irq %d busy?\n", spi->irq);
- err = -EBUSY;
- goto err_free_gpio;
+ dev_info(&spi->dev, "trying pin change workaround on irq %d\n", spi->irq);
+ if (request_irq(spi->irq, ads7846_irq,
+ IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
+ spi->dev.driver->name, ts)) {
+ dev_dbg(&spi->dev, "irq %d busy?\n", spi->irq);
+ err = -EBUSY;
+ goto err_free_gpio;
+ }
}
err = ads784x_hwmon_register(spi, ts);
reply other threads:[~2009-01-17 0:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497120F1.7020409@nessie.de \
--to=mroth@nessie.de \
--cc=dmitry.torokhov@gmail.com \
--cc=imre.deak@nokia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox