Re: 2.6.29-rc1: [SOLVED] thinkpad problems during resume

Mike Travis
2009-01-17T19:48:47Z

Christian Borntraeger wrote:
>> commit e39ad415ac15116df213dfa2aa2a4f1b0857af9c
>> Author: Mike Travis <travis@sgi.com>
>> Date: Sun Jan 4 05:18:10 2009 -0800
>>
>> cpumask: use work_on_cpu in acpi-cpufreq.c for read_measured_perf_ctrs
>>
>> makes cpu hotplug working again. Resume from suspend to ram is still broken
>> on my Thinkpad. Looks like there is yet another patch to find....
>>
>> Ingo, Mike: reverting e39ad415ac15116df213dfa2aa2a4f1b0857af9c fixes cpu
>> hotplug on my thinkpad. Any idea how to proceed? Should we revert that
>> patch in Linus git until we know what was wrong?
>
> I forgot to revert the usb patch.
> Current status:
> 2.6.29-rc2 +
> reverted e39ad415ac15116df213dfa2aa2a4f1b0857af9c (cpumask: use work_on_cpu in
> acpi-cpufreq.c for read_measured_perf_ctrs) +
> reverted a0d4922da2e4ccb0973095d8d29f36f6b1b5f703 (USB: fix up suspend and
> resume for PCI host controllers)
>
> has a working suspend to ram on my T61p. With any of these two patches not
> reverted resume hangs.
>
> Christian

Could you try one more experiment? With your working system, please cherry
pick these commits and try it again?

68564a4... work_on_cpu: don't try to get_online_cpus() in work_on_cpu.
e1d9ec6... work_on_cpu: Use our own workqueue.
6eb714c... cpufreq: use work_on_cpu in acpi-cpufreq.c for drv_read and drv_write

>From git://git.kernel.org/pub/scm/linux/kernel/git/travis/linux-2.6-cpus4096-for-ingo.git

If that works, then try and un-revert e39ad415ac and see if it's fixed as well?

(The underlying work_on_cpu() function was causing these problems, but the 1st two
of the above should fix it.)

Thanks!
Mike