From: Roel Kluin <roel.kluin@gmail.com>
To: Eric Van Hensbergen <ericvh@gmail.com>,
rminnich@sandia.gov, lucho@ionkov.net
Cc: v9fs-developer@lists.sourceforge.net,
lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] net/9p: fid->fid is used uninitialized
Date: Sun, 18 Jan 2009 20:10:25 +0100 [thread overview]
Message-ID: <49737EA1.3080805@gmail.com> (raw)
I appear to have introduced this myself trying to fix a
signed/unsigned issue, sorry.
---
fid->fid is used uninitialized
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/net/9p/client.c b/net/9p/client.c
index 821f1ec..1eb580c 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -618,7 +618,7 @@ static struct p9_fid *p9_fid_create(struct p9_client *clnt)
return ERR_PTR(-ENOMEM);
ret = p9_idpool_get(clnt->fidpool);
- if (fid->fid < 0) {
+ if (ret < 0) {
ret = -ENOSPC;
goto error;
}
next reply other threads:[~2009-01-18 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-18 19:10 Roel Kluin [this message]
2009-01-19 5:33 ` [PATCH] net/9p: fid->fid is used uninitialized David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49737EA1.3080805@gmail.com \
--to=roel.kluin@gmail.com \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox