* [PATCH] net/9p: fid->fid is used uninitialized
@ 2009-01-18 19:10 Roel Kluin
2009-01-19 5:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-01-18 19:10 UTC (permalink / raw)
To: Eric Van Hensbergen, rminnich, lucho; +Cc: v9fs-developer, lkml
I appear to have introduced this myself trying to fix a
signed/unsigned issue, sorry.
---
fid->fid is used uninitialized
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/net/9p/client.c b/net/9p/client.c
index 821f1ec..1eb580c 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -618,7 +618,7 @@ static struct p9_fid *p9_fid_create(struct p9_client *clnt)
return ERR_PTR(-ENOMEM);
ret = p9_idpool_get(clnt->fidpool);
- if (fid->fid < 0) {
+ if (ret < 0) {
ret = -ENOSPC;
goto error;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/9p: fid->fid is used uninitialized
2009-01-18 19:10 [PATCH] net/9p: fid->fid is used uninitialized Roel Kluin
@ 2009-01-19 5:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-19 5:33 UTC (permalink / raw)
To: roel.kluin; +Cc: ericvh, rminnich, lucho, v9fs-developer, linux-kernel
From: Roel Kluin <roel.kluin@gmail.com>
Date: Sun, 18 Jan 2009 20:10:25 +0100
> fid->fid is used uninitialized
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied, thanks Roel.
Someone should look into how p9_idpool_get() errors are
propagated. Another call site uses -ENOBUFS, this location
uses -ENOSPC, and it begs the question whether we should
just use the error return given by p9_idpool_get() across
the board.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-19 5:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-18 19:10 [PATCH] net/9p: fid->fid is used uninitialized Roel Kluin
2009-01-19 5:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox