Re: [PATCH] autofs: fix the wrong usage of the deprecated task_pgrp_nr()

Serge E. Hallyn
2009-01-19T22:11:42Z

Quoting Oleg Nesterov (oleg@redhat.com):
> On 01/19, Serge E. Hallyn wrote:
> >
> > Quoting Oleg Nesterov (oleg@redhat.com):
> > >
> > > This is the next patch. This one does
> > >
> > > --- CUR/fs/autofs/inode.c~1_AUTOFS 2009-01-12 23:07:46.000000000 +0100
> > > +++ CUR/fs/autofs/inode.c 2009-01-18 06:18:49.000000000 +0100
> > > @@ -78,7 +78,7 @@ static int parse_options(char *options,
> > >
> > > *uid = current_uid();
> > > *gid = current_gid();
> > > - *pgrp = task_pgrp_nr(current);
> > > + *pgrp = task_pgrp_vnr(current);
> >
> > Ok, that was the one I had looked at earlier (though now I can't find
> > it). But that just seems wrong to me. We should certainly not be
> > caching a pid_vnr in the kernel. That is imo incomparably worse than
> > storing a pid_nr.
>
> We do not cache it. We use this pgrp as an argument for find_pid()
> right after return from parse_options(). And find_pid() uses
> current->nsproxy->pid_ns. That is why this is bugfix.

So it does. And so it is.

thanks,
-serge