Re: [PATCH] autofs: fix the wrong usage of the deprecated task_pgrp_nr()

Oleg Nesterov
2009-01-19T19:19:57Z

On 01/19, Serge E. Hallyn wrote:
>
> Quoting Oleg Nesterov (oleg@redhat.com):
> > On 01/19, Serge E. Hallyn wrote:
> > >
> > > But so there does still need to be a patch modifying parse_options()
> > > to return an error if pgrp= was not specified, right?
> >
> > Why? In that case we should use the caller's pgrp. This is what the
> > current tries to do, why should the patch change this behaviour?
>
> Well, because Ian said that not specifying it is supposed to
> be an error :) I didn't quite understand why, so am fishing
> for more info...

I think you misunderstood him. Or I am totally confused ;)

In any case. Both autofs and autofs4 use current's pgrp if this
option was not specified, and these patches doesn't change this
behaviour.

Actually, I am very much surprized this one-liner patch has so
many questions. Isn't it "obiously correct" ?

Oleg.