From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755642AbZASTww (ORCPT ); Mon, 19 Jan 2009 14:52:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752700AbZASTwk (ORCPT ); Mon, 19 Jan 2009 14:52:40 -0500 Received: from gateway-1237.mvista.com ([63.81.120.155]:60719 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752624AbZASTwj (ORCPT ); Mon, 19 Jan 2009 14:52:39 -0500 Message-ID: <4974DA27.90709@ru.mvista.com> Date: Mon, 19 Jan 2009 22:53:11 +0300 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Alan Cox Cc: Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] ide: move SFF I/O code to ide-io-sff.c References: <20090119130309.24745.40877.sendpatchset@localhost.localdomain> <4974CA81.1050506@ru.mvista.com> <20090119184951.35a52184@lxorguk.ukuu.org.uk> <200901192012.51422.bzolnier@gmail.com> In-Reply-To: <200901192012.51422.bzolnier@gmail.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bartlomiej Zolnierkiewicz wrote: >>> Tried looking at how in*()/out*() are defined on x86? >>Tried looking at how ide_mm_inb is defined on x86 >>>>It's already making function calls, without the benefit of inlining and >>> I'm afraid you're wrong here. >>I'm afraid you are the one who is wrong. The IDE layer is duplicating a >>generic level of indirection with its own code - purely because IDE >>pre-dates that core functionality. The whole IDE layer indirection can go >>away because Linux has caught up with the needs of the IDE layer. > I wish it would be so simple as I would have removed the said indirection > long time ago. Unfortunately: > - not all archs support ioread() & co. > - there is still issue with cache aliasing on some CPUs Yep, look at MIPS for an example. > Thanks, > Bart MBR, Sergei