Re: [PATCH 2/6] ide: move SFF I/O code to ide-io-sff.c

Sergei Shtylyov
2009-01-19T19:04:20Z

Alan Cox wrote:

>> Tried looking at how in*()/out*() are defined on x86?

> Tried looking at how ide_mm_inb is defined on x86

That's a bogus argument because:
- MMIO isn't much used by the IDE drivers much (normally the inline
ins*()/outs*() accessors are used;
- that's used only by generic IDE code, not by the drivers about which
I'veargued;

I've already agreed that the generic code would probably win from using
ioread*()/iowrite*().

>>>It's already making function calls, without the benefit of inlining and

>> I'm afraid you're wrong here.

> I'm afraid you are the one who is wrong. The IDE layer is duplicating a
> generic level of indirection with its own code - purely because IDE
> pre-dates that core functionality. The whole IDE layer indirection can go
> away because Linux has caught up with the needs of the IDE layer.

What IDE indirection you're talking about anyway?

> Alan

MBR, Sergei