From: Shane Hathaway <shane@hathawaymix.org>
To: linux-kernel@vger.kernel.org
Subject: uml: sigprocmask fix
Date: Mon, 19 Jan 2009 18:18:01 -0700 [thread overview]
Message-ID: <49752649.3000508@hathawaymix.org> (raw)
I just ran into the same issue described here:
http://lkml.org/lkml/2009/1/15/194
Like Americo Wang, my user mode linux compile failed when attempting to
link ".tmp_vmlinux". However, his patch is probably wrong. The problem
is that the name "sigprocmask" is getting renamed to
"kernel_sigprocmask" by a compiler directive in arch/um/Makefile, then
that name gets mangled into "sys_kernel_sigprocmask" by the
SYSCALL_DEFINE3(sigprocmask, ...) macro in kernel/signal.c.
So I added the following line to arch/um/sys-i386/sys_call_table.S:
#define sys_sigprocmask sys_kernel_sigprocmask
This made it compile and link correctly. Look at the symbols generated
by the compile of signal.c to see what I mean:
# nm kernel/signal.o | grep sigprocmask
0000008f r __kstrtab_kernel_sigprocmask
00000040 r __ksymtab_kernel_sigprocmask
00001ea6 T kernel_sigprocmask
00002d67 T sys_kernel_sigprocmask
00001faf T sys_rt_sigprocmask
Unfortunately, it's a mystery to me that others haven't run into this
before.
Shane
next reply other threads:[~2009-01-20 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 1:18 Shane Hathaway [this message]
2009-01-22 16:20 ` uml: sigprocmask fix Américo Wang
2009-01-22 20:15 ` Shane Hathaway
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49752649.3000508@hathawaymix.org \
--to=shane@hathawaymix.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox