From: Jonathan Cameron <Jonathan.Cameron@gmail.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Mark Brown <broonie@sirena.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@kernel.org>
Subject: regulator: Add disable_on_boot flag to constraints.
Date: Tue, 20 Jan 2009 13:19:44 +0000 [thread overview]
Message-ID: <4975CF70.5080802@gmail.com> (raw)
In-Reply-To: <4975CAF5.9090607@cam.ac.uk>
From: Jonathan Cameron <jic23@cam.ac.uk>
regulator: Add disable_on_boot flag to constraints.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
---
Changes in response to Mark Browns comments.
Patch changed to disable_on_boot for more flexibility.
This only really involved removing the check in the enable code
found in the previous patch.
This is intended to allow the disabling of regulators during
registration. Typical use case is regulators that aren't
actually connected to anything.
This is against a clean 2.6.29-rc2-git1 tree.
drivers/regulator/core.c | 19 ++++++++++++++++++-
include/linux/regulator/machine.h | 7 ++++---
2 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index f511a40..7d57338 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -709,7 +709,14 @@ static int set_machine_constraints(struct
regulator_dev *rdev,
goto out;
}
}
-
+ /* Sanity check */
+ if (constraints->always_on && constraints->disable_on_boot) {
+ printk(KERN_ERR "%s: always on and disable at boot both set for
%s\n",
+ __func__, name);
+ rdev->constraints = NULL;
+ ret = -EINVAL;
+ goto out;
+ }
/* if always_on is set then turn the regulator on if it's not
* already on. */
if (constraints->always_on && ops->enable &&
@@ -722,6 +729,16 @@ static int set_machine_constraints(struct
regulator_dev *rdev,
rdev->constraints = NULL;
goto out;
}
+ } else if (constraints->disable_on_boot && ops->disable &&
+ ((ops->is_enabled && ops->is_enabled(rdev)) ||
+ (!ops->is_enabled && constraints->boot_on))) {
+ ret = ops->disable(rdev);
+ if (ret < 0) {
+ printk(KERN_ERR "%s: failed to disable %s\n",
+ __func__, name);
+ rdev->constraints = NULL;
+ goto out;
+ }
}
print_constraints(rdev);
diff --git a/include/linux/regulator/machine.h
b/include/linux/regulator/machine.h
index 3794773..fc0a641 100644
--- a/include/linux/regulator/machine.h
+++ b/include/linux/regulator/machine.h
@@ -112,10 +112,10 @@ struct regulation_constraints {
suspend_state_t initial_state; /* suspend state to set at init */
/* constriant flags */
- unsigned always_on:1; /* regulator never off when system is on */
- unsigned boot_on:1; /* bootloader/firmware enabled regulator */
- unsigned apply_uV:1; /* apply uV constraint iff min == max */
+ unsigned always_on:1; /* regulator never off when system on */
+ unsigned boot_on:1; /* bootloader/firmware enabled reg */
+ unsigned disable_on_boot:1; /* regulator to be disabled at boot */
+ unsigned apply_uV:1; /* apply uV constraint iff min == max */
};
/**
next prev parent reply other threads:[~2009-01-20 13:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 12:07 regulator: Add always off to constraints Jonathan Cameron
2009-01-20 12:43 ` Mark Brown
2009-01-20 13:00 ` Jonathan Cameron
2009-01-20 13:19 ` Jonathan Cameron [this message]
2009-01-20 20:14 ` regulator: Add disable_on_boot flag " Liam Girdwood
2009-01-21 14:44 ` Jonathan Cameron
2009-03-29 19:25 ` Jonathan Cameron
2009-03-30 9:52 ` Mark Brown
2009-03-31 10:55 ` Mark Brown
2009-01-20 20:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4975CF70.5080802@gmail.com \
--to=jonathan.cameron@gmail.com \
--cc=broonie@sirena.org.uk \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).