* 2.6.28(.1) and netlink: scheduling while atomic
@ 2009-01-21 9:29 Kövesdi György
2009-01-21 9:54 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: Kövesdi György @ 2009-01-21 9:29 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Netfilter Developer Mailing List
Hi,
The new netlink interface allows to add NAT directly to a conntrack entry.
If it is used when the moudule nf-nat-ipv4 is not loaded in, it results in
crash:
BUG: scheduling while atomic
It is in the kernels 2.6.28 and 2.6.28.1 in the function
ctnetlink_parse_nat_setup(): it calls request_module() which causes the
problem. If the module is already loaded, then there is no problem.
Regards:
K. Gy.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.6.28(.1) and netlink: scheduling while atomic
2009-01-21 9:29 2.6.28(.1) and netlink: scheduling while atomic Kövesdi György
@ 2009-01-21 9:54 ` Patrick McHardy
2009-01-21 10:25 ` Kövesdi György
0 siblings, 1 reply; 3+ messages in thread
From: Patrick McHardy @ 2009-01-21 9:54 UTC (permalink / raw)
To: Kövesdi György
Cc: Linux Kernel Mailing List, Netfilter Developer Mailing List
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
Kövesdi György wrote:
> The new netlink interface allows to add NAT directly to a conntrack entry.
> If it is used when the moudule nf-nat-ipv4 is not loaded in, it results in
> crash:
> BUG: scheduling while atomic
> It is in the kernels 2.6.28 and 2.6.28.1 in the function
> ctnetlink_parse_nat_setup(): it calls request_module() which causes the
> problem. If the module is already loaded, then there is no problem.
Thanks for the report. Does this patch fix it?
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 682 bytes --]
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index 3dddec6..c32a7e8 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -831,13 +831,16 @@ ctnetlink_parse_nat_setup(struct nf_conn *ct,
if (!parse_nat_setup) {
#ifdef CONFIG_MODULES
rcu_read_unlock();
+ spin_unlock_bh(&nf_conntrack_lock);
nfnl_unlock();
if (request_module("nf-nat-ipv4") < 0) {
nfnl_lock();
+ spin_lock_bh(&nf_conntrack_lock);
rcu_read_lock();
return -EOPNOTSUPP;
}
nfnl_lock();
+ spin_lock_bh(&nf_conntrack_lock);
rcu_read_lock();
if (nfnetlink_parse_nat_setup_hook)
return -EAGAIN;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-21 10:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-21 9:29 2.6.28(.1) and netlink: scheduling while atomic Kövesdi György
2009-01-21 9:54 ` Patrick McHardy
2009-01-21 10:25 ` Kövesdi György
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox