From: Andrew McGregor <andrew@indranet.co.nz>
To: "O.Sezer" <sezero@superonline.com>, linux-kernel@vger.kernel.org
Cc: zander@minion.de
Subject: Re: rmap and nvidia?
Date: Wed, 18 Dec 2002 08:35:22 +1300 [thread overview]
Message-ID: <49770000.1040153722@localhost.localdomain> (raw)
In-Reply-To: <3DFE522A.6010803@superonline.com>
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
So, first apply the patch for 4191 from www.minion.de, then the attached
one based on yours. Been running overnight and beaten on by XScreesaver,
no memory leak anymore.
Andrew
--On Tuesday, December 17, 2002 00:22:34 +0200 "O.Sezer"
<sezero@superonline.com> wrote:
> Is this patch correct in any way?
> (Ripped out of the 2.5 patch and modified some).
>
> Thanks.
>
[-- Attachment #2: NVIDIA_kernel-1.0-4191-2.5-pte_unmap.diff --]
[-- Type: application/octet-stream, Size: 1607 bytes --]
--- NVIDIA_kernel-1.0-4191-2.5-minion/nv-linux.h 2002-12-18 08:25:50.000000000 +1300
+++ NVIDIA_kernel-1.0-4191-2.5/nv-linux.h 2002-12-17 22:03:31.000000000 +1300
@@ -151,21 +151,27 @@
# define SMP_NUM_CPUS smp_num_cpus
#endif
-#ifdef KERNEL_2_5
-#define PTE_OFFSET(pmd, address, pte) (pte = *pte_offset_map(pmd, address))
+#ifdef pte_offset_map /* rmap-vm or 2.5 */
+#define PTE_OFFSET(pmd, address, pte) \
+ { \
+ pte_t *pPTE; \
+ pPTE = pte_offset_map(pmd, address); \
+ pte = *pPTE; \
+ pte_unmap(pPTE); \
+ }
#else
-#ifdef pte_offset_atomic
+#ifdef pte_offset_atomic /* aa-vm */
#define PTE_OFFSET(pmd, address, pte) \
- { \
+ { \
pte_t *pPTE; \
pPTE = pte_offset_atomic(pmd, address); \
pte = *pPTE; \
pte_kunmap(pPTE); \
}
-#else /* !pte_offset_atomic */
+#else /* !pte_offset_atomic */
#define PTE_OFFSET(pmd, address, pte) (pte = *pte_offset(pmd, address))
-#endif /* pte_offset_atomic */
-#endif /* KERNEL_2_5 */
+#endif /* pte_offset_atomic */
+#endif /* pte_offset_map */
#define NV_PAGE_ALIGN(addr) ( ((addr) + PAGE_SIZE - 1) / PAGE_SIZE)
#define NV_MASK_OFFSET(addr) ( (addr) & (PAGE_SIZE - 1) )
next prev parent reply other threads:[~2002-12-17 19:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-16 22:22 rmap and nvidia? O.Sezer
2002-12-16 23:17 ` Eyal Lebedinsky
2002-12-17 9:58 ` Andrew McGregor
2002-12-17 19:35 ` Andrew McGregor [this message]
2002-12-17 20:14 ` O.Sezer
-- strict thread matches above, loose matches on Subject: below --
2002-12-16 14:25 O.Sezer
2002-12-16 15:42 ` William Lee Irwin III
2002-12-14 9:36 mdew
2002-12-14 9:38 ` William Lee Irwin III
2002-12-14 9:46 ` mdew
2002-12-14 14:26 ` Rik van Riel
2002-12-15 1:23 ` Eyal Lebedinsky
2002-12-15 1:28 ` Philip Dodd
2002-12-15 1:40 ` Eyal Lebedinsky
2002-12-16 13:32 ` Ducrot Bruno
2002-12-16 18:42 ` Andrew McGregor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49770000.1040153722@localhost.localdomain \
--to=andrew@indranet.co.nz \
--cc=linux-kernel@vger.kernel.org \
--cc=sezero@superonline.com \
--cc=zander@minion.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox