Re: Confusion in usr/include/asm-generic/fcntl.h

Kyle McMartin
2009-01-21T14:30:06Z

On Wed, Jan 21, 2009 at 01:13:16PM +0100, Arnd Bergmann wrote:
> On Wednesday 21 January 2009, Sam Ravnborg wrote:
> > Could we add a new symbol for this?
> > We know we are going to use this in several places so a simpler variant
> > would be more readable.
> >
> > Something like:
> >
> > #ifdef __64BIT
> > ...
> > #endif
> >
> > When we define __64BIT we would use the  __BITS_PER_LONG == 64 check.
>
> I would prefer using the __BITS_PER_LONG == 64 check directly, because
> it gives you a warning when __BITS_PER_LONG is undefined, whereas the
> #ifdef check gets easily fooled by include order problems. Note that
> this is not a problem in the kernel for CONFIG_* symbols which are
> always defined before the first #include.
>

This is cool with me Arnd. Rock on. :)

cheers, Kyle