Re: Confusion in usr/include/asm-generic/fcntl.h

H. Peter Anvin
2009-01-21T16:48:50Z

Arnd Bergmann wrote:
>
> I would prefer using the __BITS_PER_LONG == 64 check directly, because
> it gives you a warning when __BITS_PER_LONG is undefined, whereas the
> #ifdef check gets easily fooled by include order problems. Note that
> this is not a problem in the kernel for CONFIG_* symbols which are
> always defined before the first #include.
>

I fully agree with this. It actually *is* a problem for CONFIG_*
symbols too, since people typo them all the time.

-hpa