* [PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR
@ 2009-01-22 1:46 Lai Jiangshan
2009-01-22 7:17 ` Paul E. McKenney
0 siblings, 1 reply; 5+ messages in thread
From: Lai Jiangshan @ 2009-01-22 1:46 UTC (permalink / raw)
To: Paul E. McKenney, Ingo Molnar, Linux Kernel Mailing List
Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR
tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.
These two are the same exactly except:
the old one "depends on CLASSIC_RCU"
the new one "depends on CLASSIC_RCU || TREE_RCU"
This patch remove the old one.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 4c9ae60..e770e85 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
config RCU_CPU_STALL_DETECTOR
bool "Check for stalled CPUs delaying RCU grace periods"
- depends on CLASSIC_RCU
- default n
- help
- This option causes RCU to printk information on which
- CPUs are delaying the current grace period, but only when
- the grace period extends for excessive time periods.
-
- Say Y if you want RCU to perform such checks.
-
- Say N if you are unsure.
-
-config RCU_CPU_STALL_DETECTOR
- bool "Check for stalled CPUs delaying RCU grace periods"
depends on CLASSIC_RCU || TREE_RCU
default n
help
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR
2009-01-22 1:46 [PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR Lai Jiangshan
@ 2009-01-22 7:17 ` Paul E. McKenney
2009-01-22 8:30 ` Ingo Molnar
0 siblings, 1 reply; 5+ messages in thread
From: Paul E. McKenney @ 2009-01-22 7:17 UTC (permalink / raw)
To: Lai Jiangshan; +Cc: Ingo Molnar, Linux Kernel Mailing List
On Thu, Jan 22, 2009 at 09:46:38AM +0800, Lai Jiangshan wrote:
>
> Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR
>
> tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.
>
> These two are the same exactly except:
> the old one "depends on CLASSIC_RCU"
> the new one "depends on CLASSIC_RCU || TREE_RCU"
>
> This patch remove the old one.
Good eyes!
However, Jiri Kosina has already queued this up for the trivial tree:
http://lkml.org/lkml/2009/1/15/218
Thanx, Paul
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 4c9ae60..e770e85 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
>
> config RCU_CPU_STALL_DETECTOR
> bool "Check for stalled CPUs delaying RCU grace periods"
> - depends on CLASSIC_RCU
> - default n
> - help
> - This option causes RCU to printk information on which
> - CPUs are delaying the current grace period, but only when
> - the grace period extends for excessive time periods.
> -
> - Say Y if you want RCU to perform such checks.
> -
> - Say N if you are unsure.
> -
> -config RCU_CPU_STALL_DETECTOR
> - bool "Check for stalled CPUs delaying RCU grace periods"
> depends on CLASSIC_RCU || TREE_RCU
> default n
> help
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR
2009-01-22 7:17 ` Paul E. McKenney
@ 2009-01-22 8:30 ` Ingo Molnar
2009-01-22 9:45 ` Paul E. McKenney
2009-01-22 9:48 ` Jiri Kosina
0 siblings, 2 replies; 5+ messages in thread
From: Ingo Molnar @ 2009-01-22 8:30 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: Lai Jiangshan, Linux Kernel Mailing List
* Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> On Thu, Jan 22, 2009 at 09:46:38AM +0800, Lai Jiangshan wrote:
> >
> > Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR
> >
> > tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.
> >
> > These two are the same exactly except:
> > the old one "depends on CLASSIC_RCU"
> > the new one "depends on CLASSIC_RCU || TREE_RCU"
> >
> > This patch remove the old one.
>
> Good eyes!
>
> However, Jiri Kosina has already queued this up for the trivial tree:
>
> http://lkml.org/lkml/2009/1/15/218
i've queued it up in tip/core/urgent, as we already touch the RCU Kconfig
structure there.
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR
2009-01-22 8:30 ` Ingo Molnar
@ 2009-01-22 9:45 ` Paul E. McKenney
2009-01-22 9:48 ` Jiri Kosina
1 sibling, 0 replies; 5+ messages in thread
From: Paul E. McKenney @ 2009-01-22 9:45 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Lai Jiangshan, Linux Kernel Mailing List, jkosina
On Thu, Jan 22, 2009 at 09:30:23AM +0100, Ingo Molnar wrote:
>
> * Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
>
> > On Thu, Jan 22, 2009 at 09:46:38AM +0800, Lai Jiangshan wrote:
> > >
> > > Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR
> > >
> > > tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.
> > >
> > > These two are the same exactly except:
> > > the old one "depends on CLASSIC_RCU"
> > > the new one "depends on CLASSIC_RCU || TREE_RCU"
> > >
> > > This patch remove the old one.
> >
> > Good eyes!
> >
> > However, Jiri Kosina has already queued this up for the trivial tree:
> >
> > http://lkml.org/lkml/2009/1/15/218
>
> i've queued it up in tip/core/urgent, as we already touch the RCU Kconfig
> structure there.
Works for me!
Thanx, Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR
2009-01-22 8:30 ` Ingo Molnar
2009-01-22 9:45 ` Paul E. McKenney
@ 2009-01-22 9:48 ` Jiri Kosina
1 sibling, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2009-01-22 9:48 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Paul E. McKenney, Lai Jiangshan, Linux Kernel Mailing List
On Thu, 22 Jan 2009, Ingo Molnar wrote:
> > > Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR
> > >
> > > tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.
> > >
> > > These two are the same exactly except:
> > > the old one "depends on CLASSIC_RCU"
> > > the new one "depends on CLASSIC_RCU || TREE_RCU"
> > >
> > > This patch remove the old one.
> >
> > Good eyes!
> >
> > However, Jiri Kosina has already queued this up for the trivial tree:
> >
> > http://lkml.org/lkml/2009/1/15/218
>
> i've queued it up in tip/core/urgent, as we already touch the RCU Kconfig
> structure there.
No problem, I have dropped that.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-01-22 9:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-22 1:46 [PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR Lai Jiangshan
2009-01-22 7:17 ` Paul E. McKenney
2009-01-22 8:30 ` Ingo Molnar
2009-01-22 9:45 ` Paul E. McKenney
2009-01-22 9:48 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox