public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sysfs: Take sysfs_mutex when fetching the root inode.
Date: Fri, 23 Jan 2009 15:28:14 +0900	[thread overview]
Message-ID: <4979637E.4070706@kernel.org> (raw)
In-Reply-To: <m13afch1sw.fsf@fess.ebiederm.org>

Eric W. Biederman wrote:
> sysfs_get_inode ultimately calls sysfs_count_nlink when the a
> directory inode is fectched.  sysfs_count_nlink needs to be
> called under the sysfs_mutex to guard against the unlikely
> but possible scenario that the root directory is changing
> as we are counting the number entries in it, and just in
> general to be consistent.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

      parent reply	other threads:[~2009-01-23  6:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21 19:55 [PATCH] sysfs: Take sysfs_mutex when fetching the root inode Eric W. Biederman
2009-01-22 16:49 ` [PATCH] sysfs: Reference sysfs_dirent from sysfs inodes Eric W. Biederman
2009-01-23  6:33   ` Tejun Heo
2009-01-27 23:44     ` Andrew Morton
2009-01-28  0:47       ` Tejun Heo
2009-02-02 17:03         ` Eric W. Biederman
2009-01-23  6:28 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4979637E.4070706@kernel.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cornelia.huck@de.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox