From: "H. Peter Anvin" <hpa@zytor.com>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC v2 -tip 0/3] x86: reduce fixup of uaccess
Date: Fri, 23 Jan 2009 20:39:47 -0800 [thread overview]
Message-ID: <497A9B93.2050703@zytor.com> (raw)
In-Reply-To: <497A5737.8030408@ct.jp.nec.com>
Hiroshi Shimamoto wrote:
> This patch series redues fixup code for exceptions of uaccess in signal.
>
> There is a lot of fixup code which is generated by using __{get|put}_user.
> I think that code can be reduced. The concept is that to add uaccess_err in
> thread_info and set it to -EFAULT on exception, finally check this value on
> the last of function.
>
> The code size reductions are below;
> $ size *signal*.o.*
> text data bss dec hex filename
> 4596 0 0 4596 11f4 ia32_signal.o.new
> 6006 0 0 6006 1776 ia32_signal.o.old
> 3583 0 0 3583 dff signal.o.new
> 4540 0 0 4540 11bc signal.o.old
> 3863 0 0 3863 f17 signal32.o.new
> 4876 0 0 4876 130c signal32.o.old
> [ signal32.o means signal.o on 32-bit. ]
>
Applied to tip:x86/uaccess. I haven't tested it much yet, but at least
a visual lookover looks good.
Thanks!
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
prev parent reply other threads:[~2009-01-24 4:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 3:06 [RFC -tip 0/4] x86: reduce fixup of uaccess Hiroshi Shimamoto
2009-01-06 3:08 ` [RFC -tip 1/4] x86: uaccess: rename __put_user_u64() to __put_user_asm_u64() Hiroshi Shimamoto
2009-01-06 3:08 ` [RFC -tip 2/4] x86: uaccess: introduce new __{get|put}_user exception handling framework Hiroshi Shimamoto
2009-01-06 3:09 ` [RFC -tip 3/4] x86: signal: use __{get|put}_user_ex " Hiroshi Shimamoto
2009-01-06 3:10 ` [RFC -tip 4/4] x86: ia32_signal: " Hiroshi Shimamoto
2009-01-06 10:09 ` [RFC -tip 0/4] x86: reduce fixup of uaccess Ingo Molnar
2009-01-07 9:33 ` H. Peter Anvin
2009-01-08 1:43 ` Hiroshi Shimamoto
2009-01-23 23:48 ` [RFC v2 -tip 0/3] " Hiroshi Shimamoto
2009-01-23 23:49 ` [RFC v2 -tip 1/3] x86: uaccess: introduce try and catch framework Hiroshi Shimamoto
2009-01-23 23:50 ` [RFC v2 -tip 2/3] x86: signal: use {get|put}_user_try and catch Hiroshi Shimamoto
2009-01-23 23:50 ` [RFC v2 -tip 3/3] x86: ia32_signal: " Hiroshi Shimamoto
2009-01-24 7:36 ` Cyrill Gorcunov
2009-01-26 18:31 ` Hiroshi Shimamoto
2009-01-26 18:56 ` Cyrill Gorcunov
2009-01-24 0:51 ` [RFC v2 -tip 0/3] x86: reduce fixup of uaccess H. Peter Anvin
2009-01-24 4:39 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497A9B93.2050703@zytor.com \
--to=hpa@zytor.com \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox