From: Randy Dunlap <randy.dunlap@oracle.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org,
kristen.c.accardi@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pcie hotplug: Change link order of pciehp
Date: Mon, 26 Jan 2009 16:44:52 -0800 [thread overview]
Message-ID: <497E5904.9030407@oracle.com> (raw)
In-Reply-To: <20090127003743.GA27711@srcf.ucam.org>
Matthew Garrett wrote:
> Some hardware exposes PCIE slots in such a way that they can be claimed by
> either the acpiphp or pciehp driver. pciehp is the preferred driver if the
> firmware allows the OS to claim control via the _OSC method so should be
> loaded first - if it fails to bind (either due to a missing _OSC method or
> the firmware refusing to hand off control) then we can fall back to acpiphp or
> a vendor-specific driver.
>
> This patch simply changes the link order to ensure that pciehp will be
> initialised before acpiphp if both are statically built into the kernel.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
Hi,
I'd prefer to have a comment in the Makefile (not just in git)
that link order is important for those 2 drivers and why.
We do that in several other similar situations and I believe that
having it in the Makefile is preferable.
> ---
>
> diff --git a/drivers/pci/hotplug/Makefile b/drivers/pci/hotplug/Makefile
> index e31fb91..a024b44 100644
> --- a/drivers/pci/hotplug/Makefile
> +++ b/drivers/pci/hotplug/Makefile
> @@ -5,11 +5,11 @@
> obj-$(CONFIG_HOTPLUG_PCI) += pci_hotplug.o
> obj-$(CONFIG_HOTPLUG_PCI_COMPAQ) += cpqphp.o
> obj-$(CONFIG_HOTPLUG_PCI_IBM) += ibmphp.o
> +obj-$(CONFIG_HOTPLUG_PCI_PCIE) += pciehp.o
> obj-$(CONFIG_HOTPLUG_PCI_ACPI) += acpiphp.o
> obj-$(CONFIG_HOTPLUG_PCI_ACPI_IBM) += acpiphp_ibm.o
> obj-$(CONFIG_HOTPLUG_PCI_CPCI_ZT5550) += cpcihp_zt5550.o
> obj-$(CONFIG_HOTPLUG_PCI_CPCI_GENERIC) += cpcihp_generic.o
> -obj-$(CONFIG_HOTPLUG_PCI_PCIE) += pciehp.o
> obj-$(CONFIG_HOTPLUG_PCI_SHPC) += shpchp.o
> obj-$(CONFIG_HOTPLUG_PCI_RPA) += rpaphp.o
> obj-$(CONFIG_HOTPLUG_PCI_RPA_DLPAR) += rpadlpar_io.o
>
--
~Randy
next prev parent reply other threads:[~2009-01-27 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 0:37 [PATCH] pcie hotplug: Change link order of pciehp Matthew Garrett
2009-01-27 0:44 ` Randy Dunlap [this message]
2009-01-27 1:03 ` Matthew Garrett
2009-01-27 2:18 ` Randy Dunlap
2009-01-27 23:37 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497E5904.9030407@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox