public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Brian Gerst <brgerst@gmail.com>,
	linux-kernel@vger.kernel.org,
	James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] x86-32: Fix __per_cpu_load relocation
Date: Tue, 27 Jan 2009 13:03:04 +0900	[thread overview]
Message-ID: <497E8778.9060503@gmail.com> (raw)
In-Reply-To: <497E6B34.1020508@kernel.org>

(cc'ing James Bottomley.)

Tejun Heo wrote:
> Ingo Molnar wrote:
>> * Brian Gerst <brgerst@gmail.com> wrote:
>>
>>> This patch fixes this error:
>>> WARNING: Absolute relocations present
>>> Offset     Info     Type     Sym.Value Sym.Name
>>> c0a4e07d 00e78001   R_386_32 c0ab0000  __per_cpu_load
>>>
>>> Now, __per_cpu_load is a section-relative symbol:
>>> c0aa4000 D __per_cpu_load
>>> c0aa4000 A __per_cpu_load_abs
>>>
>>> Signed-off-by: Brian Gerst <brgerst@gmail.com>
>> Applied to tip/core/percpu, thanks Brian!
> 
> Heh.. Thanks.  Sorry about lack of response.  It's lunar new year's
> day here and I'm off till tomorrow.  I'll start reviewing and
> integrating posted patches from tomorrow.

Well, I just had time to do it.  All the patches look fine to me.
Very nice cleanup.  The git tree is at the following URL.

  http://git.kernel.org/?p=linux/kernel/git/tj/misc.git;a=shortlog;h=tj-percpu
  git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git tj-percpu

The head commit is 2697fbd5faf19c84c17441b1752bdcbdcfd1248c.  James,
this patchset converts voyager to share generic x86 percpu code.  Can
you please review whether the change looks good for voyager?

Thanks.

-- 
tejun

  reply	other threads:[~2009-01-27  4:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090126103243.GA31307@elte.hu>
2009-01-26 13:44 ` [PATCH] x86-32: Fix __per_cpu_load relocation Brian Gerst
2009-01-26 14:18   ` Ingo Molnar
2009-01-27  2:02     ` Tejun Heo
2009-01-27  4:03       ` Tejun Heo [this message]
2009-01-27  5:03         ` James Bottomley
2009-01-27  5:29           ` [PATCH 1/2 #tj-percpu] x86: fix build breakage on voyage Tejun Heo
2009-01-27  5:29             ` [PATCH 2/2 #tj-percpu] x86: clean up indentation in setup_per_cpu_areas() Tejun Heo
2009-01-27 11:37             ` [PATCH 1/2 #tj-percpu] x86: fix build breakage on voyage Ingo Molnar
2009-01-27 11:47               ` Tejun Heo
2009-01-27 12:50                 ` Brian Gerst
2009-01-27 13:11                 ` Ingo Molnar
2009-01-27 13:21                   ` Ingo Molnar
2009-01-27 15:33                 ` James Bottomley
2009-01-27 15:31               ` James Bottomley
2009-01-27 15:50                 ` Ingo Molnar
2009-01-27 16:04                   ` James Bottomley
2009-01-27 16:25                     ` Brian Gerst
2009-01-27 16:53                       ` James Bottomley
2009-01-27 10:52         ` [PATCH] x86-32: Fix __per_cpu_load relocation Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=497E8778.9060503@gmail.com \
    --to=htejun@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=brgerst@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox