Re: [PATCH] x86-32: Fix __per_cpu_load relocation

Tejun Heo
2009-01-27T04:03:18Z

(cc'ing James Bottomley.)

Tejun Heo wrote:
> Ingo Molnar wrote:
>> * Brian Gerst <brgerst@gmail.com> wrote:
>>
>>> This patch fixes this error:
>>> WARNING: Absolute relocations present
>>> Offset Info Type Sym.Value Sym.Name
>>> c0a4e07d 00e78001 R_386_32 c0ab0000 __per_cpu_load
>>>
>>> Now, __per_cpu_load is a section-relative symbol:
>>> c0aa4000 D __per_cpu_load
>>> c0aa4000 A __per_cpu_load_abs
>>>
>>> Signed-off-by: Brian Gerst <brgerst@gmail.com>
>> Applied to tip/core/percpu, thanks Brian!
>
> Heh.. Thanks. Sorry about lack of response. It's lunar new year's
> day here and I'm off till tomorrow. I'll start reviewing and
> integrating posted patches from tomorrow.

Well, I just had time to do it. All the patches look fine to me.
Very nice cleanup. The git tree is at the following URL.

http://git.kernel.org/?p=linux/kernel/git/tj/misc.git;a=shortlog;h=tj-percpu
git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git tj-percpu

The head commit is 2697fbd5faf19c84c17441b1752bdcbdcfd1248c. James,
this patchset converts voyager to share generic x86 percpu code. Can
you please review whether the change looks good for voyager?

Thanks.

--
tejun