From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Zachary Amsden <zach@vmware.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC WIP] x86/paravirt: add register-saving thunks to reduce caller register pressure
Date: Wed, 28 Jan 2009 15:17:25 -0800 [thread overview]
Message-ID: <4980E785.9010302@goop.org> (raw)
In-Reply-To: <1233183903.16317.242.camel@bodhitayantram.eng.vmware.com>
Zachary Amsden wrote:
>> Standard calling convention is:
>> arguments return scratch
>> x86-32 eax edx ecx eax ?
>>
>
> ecx, edx
>
OK, no scratch beyond the arg regs.
>> XXX Deal with VMI. What's their calling convention?
>>
>
> Enable/Disable have no clobbers at all.
> Save clobbers only return value, %eax
> Restore also clobbers nothing.
>
OK, they can be plugged in directly then. Use __PV_IS_CALLEE_SAVE(func)
to wrap it up in the right type.
> The patching code has gotten quite complex with the 32/64 union; let me
> apply it first and see before I comment on the patch.
>
OK. I just posted updated versions of this series, so make sure you
comment on that one.
J
next prev parent reply other threads:[~2009-01-28 23:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 18:14 [PATCH RFC WIP] x86/paravirt: add register-saving thunks to reduce caller register pressure Jeremy Fitzhardinge
2009-01-28 23:05 ` Zachary Amsden
2009-01-28 23:17 ` Jeremy Fitzhardinge [this message]
2009-01-28 23:38 ` Jeremy Fitzhardinge
2009-01-30 21:06 ` Pavel Machek
2009-02-03 15:12 ` Ingo Molnar
2009-02-03 17:23 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4980E785.9010302@goop.org \
--to=jeremy@goop.org \
--cc=Ian.Campbell@citrix.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox