From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] of: OF_IRQ should depend on IRQ_DOMAIN
Date: Mon, 06 Apr 2015 16:40:59 +0200 [thread overview]
Message-ID: <4981781.UvXHorNsu5@wuerfel> (raw)
In-Reply-To: <1428245965-19618-3-git-send-email-geert@linux-m68k.org>
On Sunday 05 April 2015 16:59:24 Geert Uytterhoeven wrote:
> If CONFIG_IRQ_DOMAIN=n:
>
> drivers/of/irq.c: In function ‘of_irq_get’:
> drivers/of/irq.c:406: error: implicit declaration of function ‘irq_find_host’
> drivers/of/irq.c:406: warning: assignment makes pointer from integer without a cast
> make[2]: *** [drivers/of/irq.o] Error 1
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/of/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index 4c98f14694458794..92adecd3ecb28fc7 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -50,7 +50,7 @@ config OF_ADDRESS_PCI
>
> config OF_IRQ
> def_bool y
> - depends on !SPARC
> + depends on !SPARC && IRQ_DOMAIN
>
> config OF_NET
> depends on NETDEVICES
>
Sparc does not set IRQ_DOMAIN, so we can probably simplify this to
config OF_IRQ
def_bool IRQ_DOMAIN
unless you want to keep the sparc antidependency explicit.
Arnd
next prev parent reply other threads:[~2015-04-06 14:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 14:59 [PATCH 0/3] of: Increase compile coverage Geert Uytterhoeven
2015-04-05 14:59 ` [PATCH 1/3] of: Allow OF to be enabled if COMPILE_TEST to increase coverage Geert Uytterhoeven
2015-04-06 13:13 ` Rob Herring
2015-04-23 12:03 ` Pantelis Antoniou
2015-04-23 18:22 ` Rob Herring
2015-04-23 18:28 ` Pantelis Antoniou
2015-04-05 14:59 ` [PATCH 2/3] of: OF_IRQ should depend on IRQ_DOMAIN Geert Uytterhoeven
2015-04-06 14:40 ` Arnd Bergmann [this message]
2015-04-06 15:26 ` Rob Herring
2015-04-06 15:26 ` Geert Uytterhoeven
2015-04-06 21:39 ` Arnd Bergmann
2015-04-15 12:54 ` Rob Herring
2015-04-05 14:59 ` [PATCH 3/3] of: Add dummy of_irq_to_resource_table() for IRQ_OF=n Geert Uytterhoeven
2015-04-15 12:54 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4981781.UvXHorNsu5@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox