[PATCH 1/4] [Linux/SCSI]: Change RECEIVE_CREDENTIAL to VLC_SA_RECEIVE_CREDENTIAL

[PATCH 1/4] [Linux/SCSI]: Change RECEIVE_CREDENTIAL to VLC_SA_RECEIVE_CREDENTIAL

[Nicholas A. Bellinger]

>From 9147996b858bc44d8253929fe0cb4acfa9795986 Mon Sep 17 00:00:00 2001
From: Nicholas Bellinger <nab@linux-iscsi.org>
Date: Tue, 27 Jan 2009 13:29:49 -0800
Subject: [PATCH 1/4] [Linux/SCSI]: Change RECEIVE_CREDENTIAL to VLC_SA_RECEIVE_CREDENTIAL

This patch adds the VARIABLE_LENGTH_CMD Service Action code:
VLC_SA_RECEIVE_CREDENTIAL and removes the incorrect CDB byte[0]
opcode define RECEIVE_CREDENTIAL.

Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
---
 include/scsi/scsi.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
index 93af6ce..aabd3d1 100644
--- a/include/scsi/scsi.h
+++ b/include/scsi/scsi.h
@@ -104,7 +104,6 @@
 #define PERSISTENT_RESERVE_IN 0x5e
 #define PERSISTENT_RESERVE_OUT 0x5f
 #define VARIABLE_LENGTH_CMD   0x7f
-#define RECEIVE_CREDENTIAL    0x7f // spc4r17 section 6.9 Table 204
 #define REPORT_LUNS           0xa0
 #define SECURITY_PROTOCOL_IN  0xa2
 #define MAINTENANCE_IN        0xa3
@@ -134,6 +133,9 @@
 #define SERVICE_ACTION_IN     0x9e
 /* values for service action in */
 #define	SAI_READ_CAPACITY_16  0x10
+/* values for VARIABLE_LENGTH_CMD service action codes
+ * see spc4r17 Section D.3.5, table D.7 and D.8 */
+#define VLC_SA_RECEIVE_CREDENTIAL 0x1800
 /* values for maintenance in */
 #define MI_REPORT_IDENTIFYING_INFORMATION 0x05
 #define MI_REPORT_TARGET_PGS  0x0a
-- 
1.5.4.1

Re: [PATCH 1/4] [Linux/SCSI]: Change RECEIVE_CREDENTIAL to VLC_SA_RECEIVE_CREDENTIAL

[Nicholas A. Bellinger]

Hi James,

Let me know if you need a fresh respin of this patch..  According to
spc4r17 section D.3.5, VLC_SA_RECEIVE_CREDENTIAL is the only
VARIABLE_LENGTH_CMD defined Service ACtion..

--nab

On Tue, 2009-01-27 at 14:02 -0800, Nicholas A. Bellinger wrote:
> >From 9147996b858bc44d8253929fe0cb4acfa9795986 Mon Sep 17 00:00:00 2001
> From: Nicholas Bellinger <nab@linux-iscsi.org>
> Date: Tue, 27 Jan 2009 13:29:49 -0800
> Subject: [PATCH 1/4] [Linux/SCSI]: Change RECEIVE_CREDENTIAL to VLC_SA_RECEIVE_CREDENTIAL
> 
> This patch adds the VARIABLE_LENGTH_CMD Service Action code:
> VLC_SA_RECEIVE_CREDENTIAL and removes the incorrect CDB byte[0]
> opcode define RECEIVE_CREDENTIAL.
> 
> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
> ---
>  include/scsi/scsi.h |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
> index 93af6ce..aabd3d1 100644
> --- a/include/scsi/scsi.h
> +++ b/include/scsi/scsi.h
> @@ -104,7 +104,6 @@
>  #define PERSISTENT_RESERVE_IN 0x5e
>  #define PERSISTENT_RESERVE_OUT 0x5f
>  #define VARIABLE_LENGTH_CMD   0x7f
> -#define RECEIVE_CREDENTIAL    0x7f // spc4r17 section 6.9 Table 204
>  #define REPORT_LUNS           0xa0
>  #define SECURITY_PROTOCOL_IN  0xa2
>  #define MAINTENANCE_IN        0xa3
> @@ -134,6 +133,9 @@
>  #define SERVICE_ACTION_IN     0x9e
>  /* values for service action in */
>  #define	SAI_READ_CAPACITY_16  0x10
> +/* values for VARIABLE_LENGTH_CMD service action codes
> + * see spc4r17 Section D.3.5, table D.7 and D.8 */
> +#define VLC_SA_RECEIVE_CREDENTIAL 0x1800
>  /* values for maintenance in */
>  #define MI_REPORT_IDENTIFYING_INFORMATION 0x05
>  #define MI_REPORT_TARGET_PGS  0x0a

Re: [PATCH 1/4] [Linux/SCSI]: Change RECEIVE_CREDENTIAL to VLC_SA_RECEIVE_CREDENTIAL

[Boaz Harrosh]

Nicholas A. Bellinger wrote:
> Hi James,
> 
> Let me know if you need a fresh respin of this patch..  According to
> spc4r17 section D.3.5, VLC_SA_RECEIVE_CREDENTIAL is the only
> VARIABLE_LENGTH_CMD defined Service ACtion..
> 
> --nab

Not accurate. See file include/scsi/osd_protocol.h in the scsi-misc
git-tree master branch. The complete OSD command set is VARIABLE_LENGTH_CMD
based. There must be others as well

Boaz

Re: [PATCH 1/4] [Linux/SCSI]: Change RECEIVE_CREDENTIAL to VLC_SA_RECEIVE_CREDENTIAL

[Nicholas A. Bellinger]

On Thu, 2009-01-29 at 13:46 +0200, Boaz Harrosh wrote:
> Nicholas A. Bellinger wrote:
> > Hi James,
> > 
> > Let me know if you need a fresh respin of this patch..  According to
> > spc4r17 section D.3.5, VLC_SA_RECEIVE_CREDENTIAL is the only
> > VARIABLE_LENGTH_CMD defined Service ACtion..
> > 
> > --nab
> 
> Not accurate. See file include/scsi/osd_protocol.h in the scsi-misc
> git-tree master branch. The complete OSD command set is VARIABLE_LENGTH_CMD
> based. There must be others as well
> 

Ok, what I meant was:

>From searching spc4r17, VLC_SA_RECEIVE_CREDENTIAL (0x1800) is the only
SPC-4 defined VARIABLE_LENGTH_CMD defined Service Action in Table D.8.
>From SPC-4, the range 0x1800 -> 0x1FFF is reserved for SPC-4 defined
VARIABLE_LENGTH_CMD SAs.  

I see that OSD SAs for VARIABLE_LENGTH_CMD opcode are defined in range
0x8800 -> 0x8FFF, so does not it make sense to add the single VLC_SA_*
prefixed define above for range 0x1800 -> 0x1FFF in
include/scsi/scsi.h..?

Many thanks for your most valuable of time,

--nab


> Boaz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>