From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756795AbZA2Wpi (ORCPT ); Thu, 29 Jan 2009 17:45:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753588AbZA2Wp2 (ORCPT ); Thu, 29 Jan 2009 17:45:28 -0500 Received: from acsinet12.oracle.com ([141.146.126.234]:25960 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbZA2Wp2 (ORCPT ); Thu, 29 Jan 2009 17:45:28 -0500 Message-ID: <49823166.4010702@oracle.com> Date: Thu, 29 Jan 2009 14:44:54 -0800 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Ingo Molnar CC: Yinghai Lu , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] x86: allow 8 more cpus could be used References: <49822B1D.9070708@kernel.org> <20090129224236.GD1465@elte.hu> In-Reply-To: <20090129224236.GD1465@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsmt700.oracle.com [141.146.40.70] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.49823169.00C3:SCFSTAT928724,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar wrote: > * Yinghai Lu wrote: > >> Impact: fix left out MARCO >> >> X86_PC will be always enabled. so need to check if we have bigsmp >> support built in before cut off more than 8 cpus. > > ah, that's a leftover reference to X86_PC. It can now be removed, together > with the Kconfig X86_PC option. > >> -#if defined(CONFIG_X86_PC) && defined(CONFIG_X86_32) >> +#if defined(CONFIG_X86_PC) && !defined(CONFIG_X86_BIGSMP) >> if (def_to_bigsmp && nr_cpu_ids > 8) { >> unsigned int cpu; >> unsigned nr; > > Could you please send a patch that removes both X86_PC and X86_BIGSMP - > and removes the above cutoff code too, so that it will be built-in all the > time? and at what cost, please? -- ~Randy