From: Yinghai Lu <yinghai@kernel.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>,
"Langsdorf, Mark" <mark.langsdorf@amd.com>,
Mike Travis <travis@sgi.com>
Subject: Re: [PATCH] x86/powernow: fix cpus_allowed brokage when acpi=off
Date: Thu, 29 Jan 2009 17:44:48 -0800 [thread overview]
Message-ID: <49825B90.8050400@kernel.org> (raw)
In-Reply-To: <200901301210.48352.rusty@rustcorp.com.au>
Rusty Russell wrote:
> On Thursday 29 January 2009 15:26:28 Yinghai Lu wrote:
>> Impact: fix current->cpus_allowed overwriting.
> ...
>> caused by
>> | commit 2fdf66b491ac706657946442789ec644cc317e1a
>> | Author: Rusty Russell <rusty@rustcorp.com.au>
>> | Date: Wed Dec 31 18:08:47 2008 -0800
>> |
>> | cpumask: convert shared_cpu_map in acpi_processor* structs to cpumask_var_t
>
> Hi Yinghai!
>
> Indeed; Mike, that contained a bad conversion of
> arch/x86/kernel/cpu/cpufreq/powernow-k8.c.
>
> This patch reverts the bad change (this code should still be converted
> to work_on_cpu of course, but that's a bigger change).
>
> Yinghai, as far as I can tell your other fixes are independent (and
> were a problem before this commit, yes?). Can you re-submit them on top
> of this patch (which is for Ingo, but against latest Linus).
no problem, after ingo pick your patch in tip/master, i will have another patch.
YH
>
> Subject: cpumask: fix powernow-k8: partial revert of 2fdf66b491ac706657946442789ec644cc317e1a
>
> Impact: fix powernow-k8 when acpi=off (or other error).
>
> There was a spurious change introduced into powernow-k8 in this patch:
> the cause if that we try to "restore" the cpus_allowed we never saved.
>
> See lkml "[PATCH] x86/powernow: fix cpus_allowed brokage when
> acpi=off" from Yinghai for the bug report.
>
next prev parent reply other threads:[~2009-01-30 1:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 4:56 [PATCH] x86/powernow: fix cpus_allowed brokage when acpi=off Yinghai Lu
2009-01-30 1:40 ` Rusty Russell
2009-01-30 1:44 ` Yinghai Lu [this message]
2009-01-30 15:17 ` Ingo Molnar
2009-01-30 16:04 ` Dave Jones
2009-01-30 20:41 ` [PATCH] x86/powernow: dont emit warning " Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49825B90.8050400@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox